Skip to content

v1.3.2 Patch #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 6, 2023
Merged

v1.3.2 Patch #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e3205e
fix GetSecurityRoles return value
asmith236 Apr 6, 2023
8d5300d
add original v1.3.3 fix
asmith236 Apr 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/certificate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ func (c *Client) RevokeCert(rvargs *RevokeCertArgs) error {
return errors.New("invalid or nonexistent values required for certificate revocation")
}

if rvargs.EffectiveDate == "" {
if rvargs.EffectiveDate == "" || rvargs.EffectiveDate == "{null}" || rvargs.EffectiveDate == "null" {
rvargs.EffectiveDate = getTimestamp()
}

Expand Down
4 changes: 2 additions & 2 deletions api/security.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ func (c *Client) DeleteSecurityIdentity(id int) error {
return nil
}

func (c *Client) GetSecurityRoles() ([]GetSecurityRolesResponse, error) {
func (c *Client) GetSecurityRoles() (GetSecurityRolesResponse, error) {
log.Println("[INFO] Getting list of Keyfactor security roles")

// Set Keyfactor-specific headers
Expand All @@ -134,7 +134,7 @@ func (c *Client) GetSecurityRoles() ([]GetSecurityRolesResponse, error) {
return nil, err
}

var jsonResp []GetSecurityRolesResponse
var jsonResp GetSecurityRolesResponse
err = json.NewDecoder(resp.Body).Decode(&jsonResp)
if err != nil {
return nil, err
Expand Down