Skip to content

Add in more secure-network logging.#171

Merged
jeresig merged 3 commits intomainfrom
secure-network-logging
Apr 10, 2026
Merged

Add in more secure-network logging.#171
jeresig merged 3 commits intomainfrom
secure-network-logging

Conversation

@jeresig
Copy link
Copy Markdown
Member

@jeresig jeresig commented Apr 9, 2026

Summary:

This adds in a bunch more logging info, including one as a post step, to help us understand what's happening with upstash and if it's still running, of if it's crashing, or something else. Especially in the context of Github's hosted runners.

Issue: FEI-XXXX

Test plan:

@jeresig jeresig self-assigned this Apr 9, 2026
@jeresig jeresig requested review from a team and jaredly April 9, 2026 20:06
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 9, 2026

🦋 Changeset detected

Latest commit: 7bda3ca

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
secure-network Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@khan-actions-bot khan-actions-bot requested review from a team and kevinb-khan and removed request for a team April 9, 2026 20:06
@khan-actions-bot
Copy link
Copy Markdown
Contributor

Gerald

Required Reviewers
  • @Khan/github-actions for changes to .gitignore, .changeset/solid-views-occur.md, actions/secure-network/action.yml, actions/secure-network/package.json

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

@khan-actions-bot khan-actions-bot requested a review from a team April 9, 2026 20:09
Copy link
Copy Markdown
Contributor

@jaredly jaredly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

solid

sudo env "PATH=$PATH" "CONF_FILES=$CONF_FILES" "EXTRA_DOMAINS=$EXTRA_DOMAINS" \
node "${{ github.action_path }}/secure-network.js"
using: "node24"
main: "main.js"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooh fancy

Comment thread actions/secure-network/action.yml Outdated
using: "node24"
main: "main.js"
post: "post.js"
post-if: "always()"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good catch!

@jeresig jeresig merged commit de6a3cb into main Apr 10, 2026
3 checks passed
@jeresig jeresig deleted the secure-network-logging branch April 10, 2026 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants