Toggle the default for --pre-push-lint from true to false #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 8, 2025
csilvers
approved these changes
May 9, 2025
Member
csilvers
left a comment
csilvers
left a comment
There was a problem hiding this comment.
I know everyone else is happy about this, but I am sad. :.(
jeresig
approved these changes
May 9, 2025
lillialexis
added a commit
to Khan/khan-dotfiles
that referenced
this pull request
May 27, 2025
…om true to false (#145) ## Summary: [See the Slack thread here for more context](https://khanacademy.slack.com/archives/C06P903SXV3/p1746624684972699). For the `frontend` repo, and for most other repos other than webapp, we have chosen not to use the `pre-push.lint` hook. In [this PR](Khan/ka-clone#23) I togged the default from `true` to `false`. So now we have to explicitly add it for webapp when setting up a computer. Related PRs: - #145 👈 you are here - Khan/ka-clone#23 - Khan/ka-clone#24 - https://github.com/Khan/our-lovely-cli/pull/1000 - https://github.com/Khan/our-lovely-cli/pull/1001 Issue: FEI-6625 ## Test plan: I actually have no idea how to test this! Author: lillialexis Reviewers: csilvers, jeresig Required Reviewers: Approved By: csilvers, jeresig Checks: Pull Request URL: #145
lillialexis
added a commit
that referenced
this pull request
May 27, 2025
## Summary: [See the Slack thread here for more context](https://khanacademy.slack.com/archives/C06P903SXV3/p1746624684972699). Before, to see if we are on the right version of `ka-clone`, Repo Rangers would check if the flags it needed were present. If they weren't, rrs would just need to update ka-clone to the latest version. But now we are making a change to ka-clone that end up *not changing* any of ka-clone's flags (it just toggles a default), so for this change, we can no longer rely on the presence/absence of flags to determine if ka-clone is up to date. Instead, we will *also* need use a --version flag to check the version of ka-clone. Related PRs: - Khan/khan-dotfiles#145 - #23 - #24 👈 you are here - https://github.com/Khan/our-lovely-cli/pull/1000 - https://github.com/Khan/our-lovely-cli/pull/1001 Issue: FEI-6625 ## Test plan: Run `ka-clone --version` and see `1` Author: lillialexis Reviewers: csilvers, jeresig Required Reviewers: Approved By: csilvers, jeresig Checks: Pull Request URL: #24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
See the Slack thread here for more context. Basically, installing the pre-push linter should be default
offin most contexts other than webapp, so this PR toggles that.Related PRs:
Issue: FEI-6625
Test plan:
ka-clone --repairin a repo, see that the hook ISN'T installed in.git/hookska-clone --repair --pre-push-lintin a repo, see that the hook IS installed in.git/hooks