Skip to content

Add types to no-extraneous-dependencies check#1791

Merged
handeyeco merged 3 commits intomainfrom
knip-13
Oct 31, 2024
Merged

Add types to no-extraneous-dependencies check#1791
handeyeco merged 3 commits intomainfrom
knip-13

Conversation

@handeyeco
Copy link
Copy Markdown
Contributor

@handeyeco handeyeco commented Oct 23, 2024

Summary:

Check types for import/no-extraneous-dependencies eslint check

Found by Knip and after talking with Jeremy we think this is the way to go.

@handeyeco handeyeco self-assigned this Oct 23, 2024
@khan-actions-bot khan-actions-bot requested a review from a team October 23, 2024 21:07
@khan-actions-bot
Copy link
Copy Markdown
Contributor

khan-actions-bot commented Oct 23, 2024

Gerald

Required Reviewers
  • @Khan/perseus for changes to yarn.lock, .changeset/swift-trees-flash.md, packages/kas/.eslintrc.js, packages/keypad-context/.eslintrc.js, packages/kmath/.eslintrc.js, packages/math-input/.eslintrc.js, packages/perseus/.eslintrc.js, packages/perseus/package.json, packages/perseus-core/.eslintrc.js, packages/perseus-core/package.json, packages/perseus-editor/.eslintrc.js, packages/perseus-editor/package.json, packages/perseus-linter/.eslintrc.js, packages/pure-markdown/.eslintrc.js, packages/simple-markdown/.eslintrc.js, packages/perseus/src/multi-items/multi-renderer.tsx, packages/perseus/src/util/graphie.test.ts

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

@handeyeco handeyeco changed the title add type check for import rule Add types to no-extraneous-dependencies check Oct 23, 2024
@handeyeco handeyeco requested a review from jeremywiebe October 23, 2024 21:10
@github-actions
Copy link
Copy Markdown
Contributor

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (e7f519f) and published it to npm. You
can install it using the tag PR1791.

Example:

yarn add @khanacademy/perseus@PR1791

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR1791

@github-actions
Copy link
Copy Markdown
Contributor

Size Change: 0 B

Total Size: 866 kB

ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 38.8 kB
packages/keypad-context/dist/es/index.js 760 B
packages/kmath/dist/es/index.js 4.27 kB
packages/math-input/dist/es/index.js 77.7 kB
packages/math-input/dist/es/strings.js 1.79 kB
packages/perseus-core/dist/es/index.js 1.48 kB
packages/perseus-editor/dist/es/index.js 281 kB
packages/perseus-linter/dist/es/index.js 22.2 kB
packages/perseus/dist/es/index.js 419 kB
packages/perseus/dist/es/strings.js 3.4 kB
packages/pure-markdown/dist/es/index.js 3.66 kB
packages/simple-markdown/dist/es/index.js 12.4 kB

compressed-size-action

@handeyeco handeyeco merged commit b119147 into main Oct 31, 2024
@handeyeco handeyeco deleted the knip-13 branch October 31, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants