-
Notifications
You must be signed in to change notification settings - Fork 364
[Image] | (CX) | Add issues panel warning for long alt text #2921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ing message about alt text length, and encourage the use of long description if alt text is too long
…ng for long alt text Adding the long alt text warning message to the perseus linter. This will make it show up in the issues panel, and it will show the red dot of doom. Issue: https://khanacademy.atlassian.net/browse/LEMS-3379 Test plan: `pnpm jest packages/perseus-linter/src/rules/image-widget.test.ts` Storybook - `?path=/docs/widgets-image-editor-demo--docs#populated-within-editor-page`
…ssues panel warning for long alt text
🗄️ Schema Change: No Changes ✅ |
🛠️ Item Splitting: No Changes ✅ |
|
Size Change: +95 B (+0.02%) Total Size: 487 kB
ℹ️ View Unchanged
|
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (5871511) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR2921If you are working in Khan Academy's frontend, you can run the below command. ./dev/tools/bump_perseus_version.ts -t PR2921If you are working in Khan Academy's webapp, you can run the below command. ./dev/tools/bump_perseus_version.js -t PR2921 |
|
Putting the video in a new comment rather than the PR description so the checks don't rerun. Screen.Recording.2025-09-24.at.3.28.17.PM.mov |
catandthemachines
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! Thank you @nishasy 😊
…-issues-panel (reset everything)
…ve stale changesets.
…ssues panel warning for long alt text
catandthemachines
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still looks good and confirmed it works. Thanks @nishasy !
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/perseus@74.0.0 ### Major Changes - [#3192](#3192) [`2d57e51583`](2d57e51) Thanks [@benchristel](https://github.com/benchristel)! - Remove the deprecated `KEScore` type. - [#3188](#3188) [`ea593fef51`](ea593fe) Thanks [@benchristel](https://github.com/benchristel)! - Remove the deprecated `getUserInput` method from `Renderer`, and delete the `UserInputArray` type. - [#3189](#3189) [`3f6e33047d`](3f6e330) Thanks [@benchristel](https://github.com/benchristel)! - Remove the deprecated `getUserInputLegacy()` method of `ServerItemRenderer`. Callers should use `getUserInput()` instead. ### Minor Changes - [#3186](#3186) [`4fc881daf8`](4fc881d) Thanks [@ivyolamit](https://github.com/ivyolamit)! - [Radio] Remove getCorrectUserInput from the radio widget to hide the "Static" switch in the widget editor - [#3157](#3157) [`9cba5197a2`](9cba519) Thanks [@Myranae](https://github.com/Myranae)! - Convert Expression to functional component and improve testing and typing - [#3178](#3178) [`5756410e90`](5756410) Thanks [@mahtabsabet](https://github.com/mahtabsabet)! - Fix JIPT localization for graphie labels ### Patch Changes - [#3193](#3193) [`d5b27f0aad`](d5b27f0) Thanks [@Myranae](https://github.com/Myranae)! - Fix console errors from adding and removing radio choices - Updated dependencies \[[`2d57e51583`](2d57e51), [`e34c3db786`](e34c3db), [`29c3c697fb`](29c3c69), [`ea593fef51`](ea593fe), [`9cba5197a2`](9cba519), [`779c55b0c3`](779c55b)]: - @khanacademy/perseus-core@23.0.0 - @khanacademy/math-input@26.3.10 - @khanacademy/perseus-linter@4.6.12 - @khanacademy/keypad-context@3.2.30 - @khanacademy/kmath@2.2.30 - @khanacademy/perseus-score@8.2.6 ## @khanacademy/perseus-core@23.0.0 ### Major Changes - [#3192](#3192) [`2d57e51583`](2d57e51) Thanks [@benchristel](https://github.com/benchristel)! - Remove the deprecated `KEScore` type. - [#3188](#3188) [`ea593fef51`](ea593fe) Thanks [@benchristel](https://github.com/benchristel)! - Remove the deprecated `getUserInput` method from `Renderer`, and delete the `UserInputArray` type. ### Minor Changes - [#3157](#3157) [`9cba5197a2`](9cba519) Thanks [@Myranae](https://github.com/Myranae)! - Convert Expression to functional component and improve testing and typing ## @khanacademy/perseus-editor@28.10.0 ### Minor Changes - [#3186](#3186) [`4fc881daf8`](4fc881d) Thanks [@ivyolamit](https://github.com/ivyolamit)! - [Radio] Remove getCorrectUserInput from the radio widget to hide the "Static" switch in the widget editor ### Patch Changes - Updated dependencies \[[`d5b27f0aad`](d5b27f0), [`4fc881daf8`](4fc881d), [`2d57e51583`](2d57e51), [`e34c3db786`](e34c3db), [`29c3c697fb`](29c3c69), [`ea593fef51`](ea593fe), [`9cba5197a2`](9cba519), [`3f6e33047d`](3f6e330), [`5756410e90`](5756410), [`779c55b0c3`](779c55b)]: - @khanacademy/perseus@74.0.0 - @khanacademy/perseus-core@23.0.0 - @khanacademy/math-input@26.3.10 - @khanacademy/perseus-linter@4.6.12 - @khanacademy/keypad-context@3.2.30 - @khanacademy/kmath@2.2.30 - @khanacademy/perseus-score@8.2.6 ## @khanacademy/keypad-context@3.2.30 ### Patch Changes - Updated dependencies \[[`2d57e51583`](2d57e51), [`ea593fef51`](ea593fe), [`9cba5197a2`](9cba519)]: - @khanacademy/perseus-core@23.0.0 ## @khanacademy/kmath@2.2.30 ### Patch Changes - Updated dependencies \[[`2d57e51583`](2d57e51), [`ea593fef51`](ea593fe), [`9cba5197a2`](9cba519)]: - @khanacademy/perseus-core@23.0.0 ## @khanacademy/math-input@26.3.10 ### Patch Changes - [#3190](#3190) [`e34c3db786`](e34c3db) Thanks [@mark-fitzgerald](https://github.com/mark-fitzgerald)! - Update Storybook to v9.1.17 (security patch) - Updated dependencies \[[`2d57e51583`](2d57e51), [`ea593fef51`](ea593fe), [`9cba5197a2`](9cba519)]: - @khanacademy/perseus-core@23.0.0 - @khanacademy/keypad-context@3.2.30 ## @khanacademy/perseus-linter@4.6.12 ### Patch Changes - [#2921](#2921) [`29c3c697fb`](29c3c69) Thanks [@nishasy](https://github.com/nishasy)! - [Image] | (CX) | Add issues panel warning for long alt text - [#3183](#3183) [`779c55b0c3`](779c55b) Thanks [@anakaren-rojas](https://github.com/anakaren-rojas)! - adds linter to radio editor - triggered when NOTA and another choice are marked as correct - Updated dependencies \[[`2d57e51583`](2d57e51), [`ea593fef51`](ea593fe), [`9cba5197a2`](9cba519)]: - @khanacademy/perseus-core@23.0.0 - @khanacademy/kmath@2.2.30 ## @khanacademy/perseus-score@8.2.6 ### Patch Changes - Updated dependencies \[[`2d57e51583`](2d57e51), [`ea593fef51`](ea593fe), [`9cba5197a2`](9cba519)]: - @khanacademy/perseus-core@23.0.0 - @khanacademy/kmath@2.2.30 Author: khan-actions-bot Reviewers: benchristel Required Reviewers: Approved By: benchristel Checks: ⏭️ 2 checks have been skipped, ✅ 6 checks were successful Pull Request URL: #3187
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/perseus@74.0.0 ### Major Changes - [#3192](#3192) [`2d57e51583`](2d57e51) Thanks [@benchristel](https://github.com/benchristel)! - Remove the deprecated `KEScore` type. - [#3188](#3188) [`ea593fef51`](ea593fe) Thanks [@benchristel](https://github.com/benchristel)! - Remove the deprecated `getUserInput` method from `Renderer`, and delete the `UserInputArray` type. - [#3189](#3189) [`3f6e33047d`](3f6e330) Thanks [@benchristel](https://github.com/benchristel)! - Remove the deprecated `getUserInputLegacy()` method of `ServerItemRenderer`. Callers should use `getUserInput()` instead. ### Minor Changes - [#3186](#3186) [`4fc881daf8`](4fc881d) Thanks [@ivyolamit](https://github.com/ivyolamit)! - [Radio] Remove getCorrectUserInput from the radio widget to hide the "Static" switch in the widget editor - [#3157](#3157) [`9cba5197a2`](9cba519) Thanks [@Myranae](https://github.com/Myranae)! - Convert Expression to functional component and improve testing and typing - [#3178](#3178) [`5756410e90`](5756410) Thanks [@mahtabsabet](https://github.com/mahtabsabet)! - Fix JIPT localization for graphie labels ### Patch Changes - [#3193](#3193) [`d5b27f0aad`](d5b27f0) Thanks [@Myranae](https://github.com/Myranae)! - Fix console errors from adding and removing radio choices - Updated dependencies \[[`2d57e51583`](2d57e51), [`e34c3db786`](e34c3db), [`29c3c697fb`](29c3c69), [`ea593fef51`](ea593fe), [`9cba5197a2`](9cba519), [`779c55b0c3`](779c55b)]: - @khanacademy/perseus-core@23.0.0 - @khanacademy/math-input@26.3.10 - @khanacademy/perseus-linter@4.6.12 - @khanacademy/keypad-context@3.2.30 - @khanacademy/kmath@2.2.30 - @khanacademy/perseus-score@8.2.6 ## @khanacademy/perseus-core@23.0.0 ### Major Changes - [#3192](#3192) [`2d57e51583`](2d57e51) Thanks [@benchristel](https://github.com/benchristel)! - Remove the deprecated `KEScore` type. - [#3188](#3188) [`ea593fef51`](ea593fe) Thanks [@benchristel](https://github.com/benchristel)! - Remove the deprecated `getUserInput` method from `Renderer`, and delete the `UserInputArray` type. ### Minor Changes - [#3157](#3157) [`9cba5197a2`](9cba519) Thanks [@Myranae](https://github.com/Myranae)! - Convert Expression to functional component and improve testing and typing ## @khanacademy/perseus-editor@28.10.0 ### Minor Changes - [#3186](#3186) [`4fc881daf8`](4fc881d) Thanks [@ivyolamit](https://github.com/ivyolamit)! - [Radio] Remove getCorrectUserInput from the radio widget to hide the "Static" switch in the widget editor ### Patch Changes - Updated dependencies \[[`d5b27f0aad`](d5b27f0), [`4fc881daf8`](4fc881d), [`2d57e51583`](2d57e51), [`e34c3db786`](e34c3db), [`29c3c697fb`](29c3c69), [`ea593fef51`](ea593fe), [`9cba5197a2`](9cba519), [`3f6e33047d`](3f6e330), [`5756410e90`](5756410), [`779c55b0c3`](779c55b)]: - @khanacademy/perseus@74.0.0 - @khanacademy/perseus-core@23.0.0 - @khanacademy/math-input@26.3.10 - @khanacademy/perseus-linter@4.6.12 - @khanacademy/keypad-context@3.2.30 - @khanacademy/kmath@2.2.30 - @khanacademy/perseus-score@8.2.6 ## @khanacademy/keypad-context@3.2.30 ### Patch Changes - Updated dependencies \[[`2d57e51583`](2d57e51), [`ea593fef51`](ea593fe), [`9cba5197a2`](9cba519)]: - @khanacademy/perseus-core@23.0.0 ## @khanacademy/kmath@2.2.30 ### Patch Changes - Updated dependencies \[[`2d57e51583`](2d57e51), [`ea593fef51`](ea593fe), [`9cba5197a2`](9cba519)]: - @khanacademy/perseus-core@23.0.0 ## @khanacademy/math-input@26.3.10 ### Patch Changes - [#3190](#3190) [`e34c3db786`](e34c3db) Thanks [@mark-fitzgerald](https://github.com/mark-fitzgerald)! - Update Storybook to v9.1.17 (security patch) - Updated dependencies \[[`2d57e51583`](2d57e51), [`ea593fef51`](ea593fe), [`9cba5197a2`](9cba519)]: - @khanacademy/perseus-core@23.0.0 - @khanacademy/keypad-context@3.2.30 ## @khanacademy/perseus-linter@4.6.12 ### Patch Changes - [#2921](#2921) [`29c3c697fb`](29c3c69) Thanks [@nishasy](https://github.com/nishasy)! - [Image] | (CX) | Add issues panel warning for long alt text - [#3183](#3183) [`779c55b0c3`](779c55b) Thanks [@anakaren-rojas](https://github.com/anakaren-rojas)! - adds linter to radio editor - triggered when NOTA and another choice are marked as correct - Updated dependencies \[[`2d57e51583`](2d57e51), [`ea593fef51`](ea593fe), [`9cba5197a2`](9cba519)]: - @khanacademy/perseus-core@23.0.0 - @khanacademy/kmath@2.2.30 ## @khanacademy/perseus-score@8.2.6 ### Patch Changes - Updated dependencies \[[`2d57e51583`](2d57e51), [`ea593fef51`](ea593fe), [`9cba5197a2`](9cba519)]: - @khanacademy/perseus-core@23.0.0 - @khanacademy/kmath@2.2.30 Author: khan-actions-bot Reviewers: benchristel Required Reviewers: Approved By: benchristel Checks: ⏭️ 2 checks have been skipped, ✅ 6 checks were successful Pull Request URL: #3187
Summary:
Adding the long alt text warning message to the perseus linter.
This will make it show up in the issues panel, and it will show
the red dot of doom.
Issue: https://khanacademy.atlassian.net/browse/LEMS-3379
Test plan:
pnpm jest packages/perseus-linter/src/rules/image-widget.test.tsStorybook
?path=/docs/widgets-image-editor-demo--docs#populated-within-editor-page