Skip to content

[Image] Update issues panel warning for ImageWidget, decorative images don't need alt text validation#2968

Merged
ivyolamit merged 2 commits intomainfrom
LEMS-3543/update-issue-panel-for-docorative
Oct 23, 2025
Merged

[Image] Update issues panel warning for ImageWidget, decorative images don't need alt text validation#2968
ivyolamit merged 2 commits intomainfrom
LEMS-3543/update-issue-panel-for-docorative

Conversation

@ivyolamit
Copy link
Copy Markdown
Contributor

@ivyolamit ivyolamit commented Oct 16, 2025

Summary:

Update issues panel warning for ImageWidget, decorative images don't need alt text validation

Before After
image image

Issue: LEMS-3543

Test plan:

  1. Navigate to the Editor Page demo
  2. Add an image widget and mark it as a Decorative image
  3. Confirm that no Warning: image-widget is found

… issues panel warning for ImageWidget, decorative images don't need alt text validation
…anel warning for ImageWidget, decorative images don't need alt text validation
@ivyolamit ivyolamit self-assigned this Oct 16, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 16, 2025

🗄️ Schema Change: No Changes ✅

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 16, 2025

🛠️ Item Splitting: No Changes ✅

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 16, 2025

Size Change: +11 B (0%)

Total Size: 496 kB

Filename Size Change
packages/perseus-linter/dist/es/index.js 7.21 kB +11 B (+0.15%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 20.8 kB
packages/keypad-context/dist/es/index.js 1 kB
packages/kmath/dist/es/index.js 5.98 kB
packages/math-input/dist/es/index.js 99.2 kB
packages/math-input/dist/es/strings.js 1.61 kB
packages/perseus-core/dist/es/index.item-splitting.js 13.1 kB
packages/perseus-core/dist/es/index.js 22.3 kB
packages/perseus-editor/dist/es/index.js 95.8 kB
packages/perseus-score/dist/es/index.js 9.2 kB
packages/perseus-utils/dist/es/index.js 403 B
packages/perseus/dist/es/index.js 204 kB
packages/perseus/dist/es/strings.js 7.71 kB
packages/pure-markdown/dist/es/index.js 1.39 kB
packages/simple-markdown/dist/es/index.js 6.71 kB

compressed-size-action

@github-actions
Copy link
Copy Markdown
Contributor

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (92500b1) and published it to npm. You
can install it using the tag PR2968.

Example:

pnpm add @khanacademy/perseus@PR2968

If you are working in Khan Academy's frontend, you can run the below command.

./dev/tools/bump_perseus_version.ts -t PR2968

If you are working in Khan Academy's webapp, you can run the below command.

./dev/tools/bump_perseus_version.js -t PR2968

Copy link
Copy Markdown
Contributor

@nishasy nishasy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

@nishasy
Copy link
Copy Markdown
Contributor

nishasy commented Oct 23, 2025

Note: We'll have to make an update to remove the warning on the alt text field if it's cleared from the decorative toggle. I think it should be pretty easy to clear the errors at the same place where the decorative toggle clears all the other fields.

Screen.Recording.2025-10-23.at.11.44.55.AM.mov

@ivyolamit
Copy link
Copy Markdown
Contributor Author

Note: We'll have to make an update to remove the warning on the alt text field if it's cleared from the decorative toggle. I think it should be pretty easy to clear the errors at the same place where the decorative toggle clears all the other fields.

this has been updated in my other PR
#2967

@ivyolamit ivyolamit merged commit f5fa5d5 into main Oct 23, 2025
23 of 24 checks passed
@ivyolamit ivyolamit deleted the LEMS-3543/update-issue-panel-for-docorative branch October 23, 2025 19:49
jeremywiebe pushed a commit that referenced this pull request Oct 24, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.


# Releases
## @khanacademy/kas@2.1.3

### Patch Changes

-   [#2982](#2982) [`24d025b7c7`](24d025b) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Include provenance information when publishing to npmjs

-   Updated dependencies \[[`24d025b7c7`](24d025b)]:
    -   @khanacademy/perseus-utils@2.1.1

## @khanacademy/keypad-context@3.2.13

### Patch Changes

-   [#2982](#2982) [`24d025b7c7`](24d025b) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Include provenance information when publishing to npmjs

-   Updated dependencies \[[`24d025b7c7`](24d025b)]:
    -   @khanacademy/perseus-core@20.1.1
    -   @khanacademy/perseus-utils@2.1.1

## @khanacademy/kmath@2.2.13

### Patch Changes

-   [#2982](#2982) [`24d025b7c7`](24d025b) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Include provenance information when publishing to npmjs

-   Updated dependencies \[[`24d025b7c7`](24d025b)]:
    -   @khanacademy/perseus-core@20.1.1
    -   @khanacademy/perseus-utils@2.1.1

## @khanacademy/math-input@26.2.14

### Patch Changes

-   [#2982](#2982) [`24d025b7c7`](24d025b) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Include provenance information when publishing to npmjs

-   Updated dependencies \[[`24d025b7c7`](24d025b)]:
    -   @khanacademy/keypad-context@3.2.13
    -   @khanacademy/perseus-core@20.1.1
    -   @khanacademy/perseus-utils@2.1.1

## @khanacademy/perseus@71.3.2

### Patch Changes

-   [#2982](#2982) [`24d025b7c7`](24d025b) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Include provenance information when publishing to npmjs

-   Updated dependencies \[[`24d025b7c7`](24d025b), [`f5fa5d5203`](f5fa5d5)]:
    -   @khanacademy/kas@2.1.3
    -   @khanacademy/keypad-context@3.2.13
    -   @khanacademy/kmath@2.2.13
    -   @khanacademy/math-input@26.2.14
    -   @khanacademy/perseus-core@20.1.1
    -   @khanacademy/perseus-linter@4.4.3
    -   @khanacademy/perseus-score@8.0.2
    -   @khanacademy/perseus-utils@2.1.1
    -   @khanacademy/pure-markdown@2.2.1
    -   @khanacademy/simple-markdown@2.1.1

## @khanacademy/perseus-core@20.1.1

### Patch Changes

-   [#2982](#2982) [`24d025b7c7`](24d025b) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Include provenance information when publishing to npmjs

-   Updated dependencies \[[`24d025b7c7`](24d025b)]:
    -   @khanacademy/kas@2.1.3
    -   @khanacademy/perseus-utils@2.1.1
    -   @khanacademy/pure-markdown@2.2.1

## @khanacademy/perseus-editor@28.5.2

### Patch Changes

-   [#2982](#2982) [`24d025b7c7`](24d025b) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Include provenance information when publishing to npmjs

-   Updated dependencies \[[`24d025b7c7`](24d025b), [`f5fa5d5203`](f5fa5d5)]:
    -   @khanacademy/kas@2.1.3
    -   @khanacademy/keypad-context@3.2.13
    -   @khanacademy/kmath@2.2.13
    -   @khanacademy/math-input@26.2.14
    -   @khanacademy/perseus@71.3.2
    -   @khanacademy/perseus-core@20.1.1
    -   @khanacademy/perseus-linter@4.4.3
    -   @khanacademy/perseus-score@8.0.2
    -   @khanacademy/perseus-utils@2.1.1
    -   @khanacademy/pure-markdown@2.2.1

## @khanacademy/perseus-linter@4.4.3

### Patch Changes

-   [#2982](#2982) [`24d025b7c7`](24d025b) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Include provenance information when publishing to npmjs


-   [#2968](#2968) [`f5fa5d5203`](f5fa5d5) Thanks [@ivyolamit](https://github.com/ivyolamit)! - Update issues panel warning for ImageWidget, decorative images don't need alt text validation

-   Updated dependencies \[[`24d025b7c7`](24d025b)]:
    -   @khanacademy/perseus-core@20.1.1
    -   @khanacademy/perseus-utils@2.1.1

## @khanacademy/perseus-score@8.0.2

### Patch Changes

-   [#2982](#2982) [`24d025b7c7`](24d025b) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Include provenance information when publishing to npmjs

-   Updated dependencies \[[`24d025b7c7`](24d025b)]:
    -   @khanacademy/kas@2.1.3
    -   @khanacademy/kmath@2.2.13
    -   @khanacademy/perseus-core@20.1.1
    -   @khanacademy/perseus-utils@2.1.1

## @khanacademy/perseus-utils@2.1.1

### Patch Changes

-   [#2982](#2982) [`24d025b7c7`](24d025b) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Include provenance information when publishing to npmjs

## @khanacademy/pure-markdown@2.2.1

### Patch Changes

-   [#2982](#2982) [`24d025b7c7`](24d025b) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Include provenance information when publishing to npmjs

-   Updated dependencies \[[`24d025b7c7`](24d025b)]:
    -   @khanacademy/perseus-utils@2.1.1
    -   @khanacademy/simple-markdown@2.1.1

## @khanacademy/simple-markdown@2.1.1

### Patch Changes

-   [#2982](#2982) [`24d025b7c7`](24d025b) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Include provenance information when publishing to npmjs

-   Updated dependencies \[[`24d025b7c7`](24d025b)]:
    -   @khanacademy/perseus-utils@2.1.1

Author: khan-actions-bot

Reviewers: jeremywiebe

Required Reviewers:

Approved By: jeremywiebe

Checks: ⏭️  1 check has been skipped, ✅ 6 checks were successful

Pull Request URL: #2975
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants