[Image] | (CX) | Make image-markdown linter rule an error instead of a warning#3267
Merged
[Image] | (CX) | Make image-markdown linter rule an error instead of a warning#3267
Conversation
…or instead of a warning It's been a while since the image-markdown rule has been added as a warning. Since content authors have had time to know that this is the recommendation, we can now change it to an error so that it will also yell at them in the pre-publish errors modal. Issue: https://khanacademy.atlassian.net/browse/LEMS-3570 Test plan: `pnpm jest packages/perseus-linter/src/rules/image-markdown.test.ts` Storybook - Go to `/?path=/story/editors-editorpage--demo` - Type in  - Confirm that the image-markdown rule is an error now
…inter rule an error instead of a warning
Contributor
🗄️ Schema Change: No Changes ✅ |
Contributor
|
Size Change: +2 B (0%) Total Size: 485 kB
ℹ️ View Unchanged
|
Contributor
🛠️ Item Splitting: No Changes ✅ |
Contributor
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (c31ed2f) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR3267If you are working in Khan Academy's frontend, you can run the below command. ./dev/tools/bump_perseus_version.ts -t PR3267If you are working in Khan Academy's webapp, you can run the below command. ./dev/tools/bump_perseus_version.js -t PR3267 |
Merged
nishasy
added a commit
that referenced
this pull request
Feb 25, 2026
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/perseus@75.3.0 ### Minor Changes - [#3270](#3270) [`0ea9b7fe1c`](0ea9b7f) Thanks [@nishasy](https://github.com/nishasy)! - [Image] | (cleanup) | Remove image-widget-upgrade feature flag ### Patch Changes - [#3279](#3279) [`876dd96e74`](876dd96) Thanks [@nishasy](https://github.com/nishasy)! - [Image] | (UX) | Add gif control buttons to explore image modal behind feature flag - [#3276](#3276) [`7682804e0e`](7682804) Thanks [@benchristel](https://github.com/benchristel)! - Internal: use the getSinusoidCoefficients and getQuadraticCoefficients functions from kmath instead of redefining them in interactive-graph.tsx. - [#3271](#3271) [`78031be86b`](78031be) Thanks [@Myranae](https://github.com/Myranae)! - Remove background flash in mobile browsers when choice is tapped - [#3275](#3275) [`8cc27db79a`](8cc27db) Thanks [@nishasy](https://github.com/nishasy)! - [Image] | (UX) | Add gif control icon buttons behind feature flag - Updated dependencies \[[`46e100430a`](46e1004), [`0ea9b7fe1c`](0ea9b7f), [`876dd96e74`](876dd96), [`7023b4dae0`](7023b4d), [`8cc27db79a`](8cc27db)]: - @khanacademy/perseus-linter@4.8.1 - @khanacademy/perseus-core@23.1.0 - @khanacademy/kmath@2.2.33 - @khanacademy/keypad-context@3.2.33 - @khanacademy/math-input@26.4.1 - @khanacademy/perseus-score@8.2.10 ## @khanacademy/perseus-core@23.1.0 ### Minor Changes - [#3270](#3270) [`0ea9b7fe1c`](0ea9b7f) Thanks [@nishasy](https://github.com/nishasy)! - [Image] | (cleanup) | Remove image-widget-upgrade feature flag ### Patch Changes - [#3279](#3279) [`876dd96e74`](876dd96) Thanks [@nishasy](https://github.com/nishasy)! - [Image] | (UX) | Add gif control buttons to explore image modal behind feature flag - [#3275](#3275) [`8cc27db79a`](8cc27db) Thanks [@nishasy](https://github.com/nishasy)! - [Image] | (UX) | Add gif control icon buttons behind feature flag ## @khanacademy/perseus-editor@28.13.0 ### Minor Changes - [#3270](#3270) [`0ea9b7fe1c`](0ea9b7f) Thanks [@nishasy](https://github.com/nishasy)! - [Image] | (cleanup) | Remove image-widget-upgrade feature flag ### Patch Changes - [#3244](#3244) [`13247bac3e`](13247ba) Thanks [@jandrade](https://github.com/jandrade)! - Updates WB `color` references to use the new `semanticColor` tokens instead. - [#3279](#3279) [`876dd96e74`](876dd96) Thanks [@nishasy](https://github.com/nishasy)! - [Image] | (UX) | Add gif control buttons to explore image modal behind feature flag - [#3275](#3275) [`8cc27db79a`](8cc27db) Thanks [@nishasy](https://github.com/nishasy)! - [Image] | (UX) | Add gif control icon buttons behind feature flag - Updated dependencies \[[`46e100430a`](46e1004), [`0ea9b7fe1c`](0ea9b7f), [`876dd96e74`](876dd96), [`7023b4dae0`](7023b4d), [`7682804e0e`](7682804), [`78031be86b`](78031be), [`8cc27db79a`](8cc27db)]: - @khanacademy/perseus-linter@4.8.1 - @khanacademy/perseus@75.3.0 - @khanacademy/perseus-core@23.1.0 - @khanacademy/kmath@2.2.33 - @khanacademy/keypad-context@3.2.33 - @khanacademy/math-input@26.4.1 - @khanacademy/perseus-score@8.2.10 ## @khanacademy/keypad-context@3.2.33 ### Patch Changes - Updated dependencies \[[`0ea9b7fe1c`](0ea9b7f), [`876dd96e74`](876dd96), [`8cc27db79a`](8cc27db)]: - @khanacademy/perseus-core@23.1.0 ## @khanacademy/kmath@2.2.33 ### Patch Changes - [#3277](#3277) [`7023b4dae0`](7023b4d) Thanks [@benchristel](https://github.com/benchristel)! - Internal: inline constant for default `toFraction()` tolerance. - Updated dependencies \[[`0ea9b7fe1c`](0ea9b7f), [`876dd96e74`](876dd96), [`8cc27db79a`](8cc27db)]: - @khanacademy/perseus-core@23.1.0 ## @khanacademy/math-input@26.4.1 ### Patch Changes - Updated dependencies \[[`0ea9b7fe1c`](0ea9b7f), [`876dd96e74`](876dd96), [`8cc27db79a`](8cc27db)]: - @khanacademy/perseus-core@23.1.0 - @khanacademy/keypad-context@3.2.33 ## @khanacademy/perseus-linter@4.8.1 ### Patch Changes - [#3267](#3267) [`46e100430a`](46e1004) Thanks [@nishasy](https://github.com/nishasy)! - [Image] | (CX) | Make image-markdown linter rule an error instead of a warning - Updated dependencies \[[`0ea9b7fe1c`](0ea9b7f), [`876dd96e74`](876dd96), [`7023b4dae0`](7023b4d), [`8cc27db79a`](8cc27db)]: - @khanacademy/perseus-core@23.1.0 - @khanacademy/kmath@2.2.33 ## @khanacademy/perseus-score@8.2.10 ### Patch Changes - Updated dependencies \[[`0ea9b7fe1c`](0ea9b7f), [`876dd96e74`](876dd96), [`7023b4dae0`](7023b4d), [`8cc27db79a`](8cc27db)]: - @khanacademy/perseus-core@23.1.0 - @khanacademy/kmath@2.2.33
catandthemachines
pushed a commit
that referenced
this pull request
Apr 1, 2026
…a warning (#3267) ## Summary: It's been a while since the image-markdown rule has been added as a warning. Since content authors have had time to know that this is the recommendation, we can now change it to an error so that it will also yell at them in the pre-publish errors modal. Issue: https://khanacademy.atlassian.net/browse/LEMS-3570 ## Test plan: `pnpm jest packages/perseus-linter/src/rules/image-markdown.test.ts` Storybook - Go to `/?path=/story/editors-editorpage--demo` - Type in  - Confirm that the image-markdown rule is an error now | Before | After | | --- | --- | | <img width="395" height="318" alt="Screenshot 2026-02-18 at 4 44 26 PM" src="https://github.com/user-attachments/assets/4785ff48-fb8a-4104-beac-059901e9d9f0" /> | <img width="381" height="316" alt="Screenshot 2026-02-18 at 4 44 40 PM" src="https://github.com/user-attachments/assets/3c446e2a-6377-4497-8ae3-349c7b612517" /> | Author: nishasy Reviewers: catandthemachines Required Reviewers: Approved By: catandthemachines Checks: ⏭️ 1 check has been skipped, ✅ 10 checks were successful Pull Request URL: #3267
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
It's been a while since the image-markdown rule has been added as a warning.
Since content authors have had time to know that this is the recommendation,
we can now change it to an error so that it will also yell at them in the
pre-publish errors modal.
Issue: https://khanacademy.atlassian.net/browse/LEMS-3570
Test plan:
pnpm jest packages/perseus-linter/src/rules/image-markdown.test.tsStorybook
/?path=/story/editors-editorpage--demo