Tabs: Add mountAllPanels prop.
#2569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fa6a5bd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Size Change: +19 B (+0.02%) Total Size: 105 kB
ℹ️ View Unchanged
|
Contributor
A new build was pushed to Chromatic! 🚀https://5e1bf4b385e3fb0020b7073c-liwcmuzdco.chromatic.com/ Chromatic results:
|
…. Defaults to `false` so tab panels are only rendered if they are visited
beaesguerra
force-pushed
the
wb-1923-mount-prop
branch
from
92a4490 to
fa6a5bd
Compare
Contributor
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
Contributor
npm Snapshot: Published🎉 Good news!! We've packaged up the latest commit from this PR (f4b218c) and published all packages with changesets to npm. You can install the packages in webapp by running: ./services/static/dev/tools/deploy_wonder_blocks.js --tag="PR2569"Packages can also be installed manually by running: pnpm add @khanacademy/wonder-blocks-<package-name>@PR2569 |
jandrade
approved these changes
Apr 24, 2025
Member
jandrade
left a comment
jandrade
left a comment
There was a problem hiding this comment.
Looks great!!, thanks for the improvement! 🚢
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/tabs #2569 +/- ##
====================================
====================================
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
beaesguerra
added a commit
that referenced
this pull request
May 9, 2025
…2593) ## Summary: This PR includes the following commits: - Set up Tabs component (#2528) - Tabs: Set up keyboard navigation and activationMode prop (#2536) - Tabs: Implement props and features (#2542) - Tabs: Styling (#2545) - Use StateSheet for tabs package stories & address snapshot flakiness (#2568) - Tabs: Add `mountAllPanels` prop. (#2569) - Tabs: Fix keyboard navigation for right-to-left (#2585) - Fix tooltip and popover bugs found when integrating with tabs (#2574) Issue: WB-773 ## Test plan: Tests pass and Tabs component works as expected Author: beaesguerra Reviewers: jandrade Required Reviewers: Approved By: jandrade Checks: ✅ 23 checks were successful, ⏭️ 3 checks have been skipped Pull Request URL: #2593
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
mountAllPanelsprop toTabs. It defaults tofalseIssue: WB-1923
Test plan:
[?path=/docs/packages-tabs-tabs--docs](http://localhost:6061/?path=/docs/packages-tabs-tabs--docs#panel%20caching))http://localhost:6061/?path=/docs/packages-tabs-tabs--docs#mount%20all%20panels)