While preprocessing the datatable format specification remove any ambiguity#230
Closed
While preprocessing the datatable format specification remove any ambiguity#230
Conversation
popescu-v
reviewed
Aug 19, 2024
popescu-v
reviewed
Aug 19, 2024
popescu-v
reviewed
Aug 19, 2024
popescu-v
reviewed
Aug 19, 2024
tramora
force-pushed
the
208-datatable-format-specification
branch
from
436e870 to
f1bc277
Compare
Collaborator
Author
|
I just noticed that @folmos-at-orange has already worked on this subject and created the related branch. |
tramora
force-pushed
the
208-datatable-format-specification
branch
from
f1bc277 to
07c360c
Compare
popescu-v
reviewed
Aug 20, 2024
popescu-v
reviewed
Aug 20, 2024
khiops/core/api.py
Outdated
| task_args["header_line"] = header_line | ||
| task_args["field_separator"] = field_separator | ||
| detect_format, header_line, field_separator = _preprocess_format_spec( | ||
| task_args.get("detect_format", True), |
Collaborator
There was a problem hiding this comment.
Why do we need to enforce the True by default here? The default True value of the detect_format kwarg of the API functions is not enough?
Collaborator
Author
There was a problem hiding this comment.
It was a preparation of the change in the khiops-api-base (call of the kh._preprocess_tasks_arguments function) where I was not sure a default value of detect_format was set.
By the way I also fixed a problem for tasks that do not have format_spec in their signature.
popescu-v
reviewed
Aug 20, 2024
popescu-v
reviewed
Aug 20, 2024
added 2 commits
August 22, 2024 10:51
…iguity before sending the parameters to khiops
The `maison` dependency just had a new 2.0 release with breaking changes (https://github.com/dbatten5/maison/releases/tag/v2.0.0) which break yamlfix (see lyz-code/yamlfix#286).
tramora
force-pushed
the
208-datatable-format-specification
branch
from
07c360c to
4ae3960
Compare
Collaborator
Author
|
To be closed as duplicated PR #234 |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should (partially) address the issue #208. The remaining fix must be done in
khiops-api-base