Skip to content

Fix various typos#323

Merged
folmos-at-orange merged 1 commit intodevfrom
fix-typos
Jan 8, 2025
Merged

Fix various typos#323
folmos-at-orange merged 1 commit intodevfrom
fix-typos

Conversation

@folmos-at-orange
Copy link
Copy Markdown
Member

@folmos-at-orange folmos-at-orange commented Dec 20, 2024 •
edited
Loading

Put your message here

TODO Before Asking for a Review

  • Rebase your branch to the latest version of dev (or main for release PRs)
  • Make sure all CI workflows are green
  • When adding a public feature/fix: Update the Unreleased section of CHANGELOG.md (no date)
  • Self-Review: Review "Files Changed" tab and fix any problems you find
  • API Docs (only if there are changes in docstrings, rst files or samples):
    • Check the docs build without warning: see the log of the API Docs workflow
    • Check that your changes render well in HTML: download the API Docs artifact and open index.html
    • If there are any problems it is faster to iterate by building locally the API Docs

@folmos-at-orange folmos-at-orange changed the title y Fix various typos Dec 20, 2024
@folmos-at-orange folmos-at-orange self-assigned this Dec 20, 2024
popescu-v
popescu-v reviewed Jan 7, 2025
View reviewed changes
Comment thread khiops/sklearn/estimators.py Outdated
popescu-v
popescu-v reviewed Jan 7, 2025
View reviewed changes
Comment thread tests/test_remote_access.py Outdated
popescu-v
popescu-v reviewed Jan 7, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@popescu-v popescu-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but:

  • there are 2 comments which can provide further fixes (potentially)
  • rebase on dev is needed

@folmos-at-orange folmos-at-orange merged commit 4e9aba0 into dev Jan 8, 2025
@folmos-at-orange folmos-at-orange deleted the fix-typos branch January 8, 2025 11:20
@folmos-at-orange folmos-at-orange added this to the 10.2.4.1 milestone Jan 15, 2025
@popescu-v popescu-v modified the milestones: 10.2.4.1, 10.3.0.0 Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@popescu-v popescu-v popescu-v approved these changes

Assignees

@folmos-at-orange folmos-at-orange

Labels

None yet

Projects

None yet

Milestone

10.3.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@folmos-at-orange @popescu-v