Skip to content

Conversation

@popescu-v
Copy link
Collaborator

@popescu-v popescu-v commented Feb 6, 2025

related_to #351


TODO Before Asking for a Review

  • Rebase your branch to the latest version of dev-v10
  • Make sure all CI workflows are green
  • Self-Review: Review "Files Changed" tab and fix any problems you find
  • API Docs (only if there are changes in docstrings, rst files or samples):
    • Check the docs build without warning: see the log of the API Docs workflow
    • Check that your changes render well in HTML: download the API Docs artifact and open index.html
    • If there are any problems it is faster to iterate by building locally the API Docs

@popescu-v popescu-v changed the base branch from dev to dev-v10 February 6, 2025 16:54
@popescu-v popescu-v self-assigned this Feb 6, 2025
@popescu-v popescu-v force-pushed the prepare-release-10-3-0-0 branch from 2cc048f to d47c8e7 Compare February 7, 2025 10:22
Copy link
Member

@folmos-at-orange folmos-at-orange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the release of the new .conda package with a phony tag (10.3.0.0-a.0) and it works. I successfully installed it my machine afterwards from khiops-dev.

One last thing:
We should change the default khiops version in the CI workflows

> rg "10.2.4" .github
.github/workflows/dev-docker.yml
4:  DEFAULT_KHIOPS_REVISION: 10.2.4
17:        default: 10.2.4

.github/workflows/tests.yml
4:  DEFAULT_SAMPLES_REVISION: 10.2.4
5:  DEFAULT_KHIOPS_DESKTOP_REVISION: 10.2.4
10:        default: 10.2.4
16:        default: 10.2.4

.github/workflows/conda.yml
6:  DEFAULT_KHIOPS_CORE_VERSION: 10.2.4
7:  DEFAULT_SAMPLES_VERSION: 10.2.4
12:        default: 10.2.4
15:        default: 10.2.4

.github/workflows/pip.yml
4:  DEFAULT_SAMPLES_REVISION: 10.2.4
9:        default: 10.2.4

@popescu-v
Copy link
Collaborator Author

popescu-v commented Feb 7, 2025

I tested the release of the new .conda package with a phony tag (10.3.0.0-a.0) and it works. I successfully installed it my machine afterwards from khiops-dev.

One last thing: We should change the default khiops version in the CI workflows

> rg "10.2.4" .github
.github/workflows/dev-docker.yml
4:  DEFAULT_KHIOPS_REVISION: 10.2.4
17:        default: 10.2.4

.github/workflows/tests.yml
4:  DEFAULT_SAMPLES_REVISION: 10.2.4
5:  DEFAULT_KHIOPS_DESKTOP_REVISION: 10.2.4
10:        default: 10.2.4
16:        default: 10.2.4

.github/workflows/conda.yml
6:  DEFAULT_KHIOPS_CORE_VERSION: 10.2.4
7:  DEFAULT_SAMPLES_VERSION: 10.2.4
12:        default: 10.2.4
15:        default: 10.2.4

.github/workflows/pip.yml
4:  DEFAULT_SAMPLES_REVISION: 10.2.4
9:        default: 10.2.4

OK, done for Khiops core, but the samples version should stay at 10.2.4 for now.

@popescu-v popescu-v merged commit bc53209 into dev-v10 Feb 7, 2025
76 checks passed
@popescu-v popescu-v deleted the prepare-release-10-3-0-0 branch February 7, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants