Skip to content

Conversation

@folmos-at-orange
Copy link
Member

@folmos-at-orange folmos-at-orange commented Feb 19, 2025

commit 3310037 (HEAD -> 356-create-dynamically-the-khiops-execution-command-from-environment-variables, origin/356-create-dynamically-the-khiops-execution-command-from-environment-variables)
Author: Felipe Olmos 92923444+folmos-at-orange@users.noreply.github.com
Date: Thu Feb 20 14:20:40 2025 +0100

Eliminate CONDA_PREFIX manipulation from runner initialization test

commit 04b202b
Author: Felipe Olmos 92923444+folmos-at-orange@users.noreply.github.com
Date: Wed Feb 19 15:33:28 2025 +0100

Add runner initialization test to the conda package tests

commit c1cd407
Author: Felipe Olmos 92923444+folmos-at-orange@users.noreply.github.com
Date: Wed Feb 19 15:11:52 2025 +0100

Fix minor bug in test CI

commit b8a163c
Author: Felipe Olmos 92923444+folmos-at-orange@users.noreply.github.com
Date: Wed Feb 19 15:30:32 2025 +0100

Add system-settings output dir to .gitignore

TODO Before Asking for a Review

  • Rebase your branch to the latest version of dev (or main for release PRs)
  • Make sure all CI workflows are green
  • When adding a public feature/fix: Update the Unreleased section of CHANGELOG.md (no date)
  • Self-Review: Review "Files Changed" tab and fix any problems you find

@folmos-at-orange folmos-at-orange changed the base branch from dev to dev-v10 February 19, 2025 14:36
@folmos-at-orange folmos-at-orange force-pushed the 356-create-dynamically-the-khiops-execution-command-from-environment-variables branch from 6e277a1 to bb81f0c Compare February 19, 2025 14:41
@folmos-at-orange folmos-at-orange self-assigned this Feb 20, 2025
@folmos-at-orange folmos-at-orange force-pushed the 356-create-dynamically-the-khiops-execution-command-from-environment-variables branch from 5a7e2fc to 3310037 Compare February 20, 2025 13:21
@folmos-at-orange folmos-at-orange changed the title 356 create dynamically the khiops execution command from environment variables Run initialization integration tests in conda CI Feb 20, 2025
@folmos-at-orange folmos-at-orange force-pushed the 356-create-dynamically-the-khiops-execution-command-from-environment-variables branch from 3310037 to 26e3e86 Compare February 20, 2025 13:32
Copy link
Collaborator

@popescu-v popescu-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the comments on the code changes.
Also:

  • rename branch so that it doesn't keep any relation to issue #356 anymore;
  • provide a concise and to-the-point description to the PR.

@folmos-at-orange folmos-at-orange force-pushed the 356-create-dynamically-the-khiops-execution-command-from-environment-variables branch from 26e3e86 to b4c963f Compare February 25, 2025 11:52
@folmos-at-orange folmos-at-orange force-pushed the 356-create-dynamically-the-khiops-execution-command-from-environment-variables branch from b4c963f to b2bf3b8 Compare February 25, 2025 12:46
Copy link
Collaborator

@popescu-v popescu-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Before merging:

  • "rename" branch so that any relation to issue #356 is removed
  • create new PR for the new branch
  • add concise, to-the-point description to the new PR
  • in the new PR's description, add link to the current (older) PR, so that we can track the discussion.

@folmos-at-orange
Copy link
Member Author

Superseeded by #364

@folmos-at-orange folmos-at-orange deleted the 356-create-dynamically-the-khiops-execution-command-from-environment-variables branch February 25, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants