-
Notifications
You must be signed in to change notification settings - Fork 2
Run initialization integration tests in conda CI #361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
folmos-at-orange
wants to merge
4
commits into
dev-v10
from
356-create-dynamically-the-khiops-execution-command-from-environment-variables
Closed
Run initialization integration tests in conda CI #361
folmos-at-orange
wants to merge
4
commits into
dev-v10
from
356-create-dynamically-the-khiops-execution-command-from-environment-variables
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6e277a1 to
bb81f0c
Compare
5a7e2fc to
3310037
Compare
3310037 to
26e3e86
Compare
popescu-v
reviewed
Feb 25, 2025
popescu-v
reviewed
Feb 25, 2025
popescu-v
reviewed
Feb 25, 2025
popescu-v
reviewed
Feb 25, 2025
popescu-v
reviewed
Feb 25, 2025
popescu-v
reviewed
Feb 25, 2025
popescu-v
requested changes
Feb 25, 2025
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the comments on the code changes.
Also:
- rename branch so that it doesn't keep any relation to issue #356 anymore;
- provide a concise and to-the-point description to the PR.
26e3e86 to
b4c963f
Compare
popescu-v
reviewed
Feb 25, 2025
b4c963f to
b2bf3b8
Compare
popescu-v
approved these changes
Feb 25, 2025
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Before merging:
- "rename" branch so that any relation to issue #356 is removed
- create new PR for the new branch
- add concise, to-the-point description to the new PR
- in the new PR's description, add link to the current (older) PR, so that we can track the discussion.
4 tasks
Member
Author
|
Superseeded by #364 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit 3310037 (HEAD -> 356-create-dynamically-the-khiops-execution-command-from-environment-variables, origin/356-create-dynamically-the-khiops-execution-command-from-environment-variables)
Author: Felipe Olmos 92923444+folmos-at-orange@users.noreply.github.com
Date: Thu Feb 20 14:20:40 2025 +0100
commit 04b202b
Author: Felipe Olmos 92923444+folmos-at-orange@users.noreply.github.com
Date: Wed Feb 19 15:33:28 2025 +0100
commit c1cd407
Author: Felipe Olmos 92923444+folmos-at-orange@users.noreply.github.com
Date: Wed Feb 19 15:11:52 2025 +0100
commit b8a163c
Author: Felipe Olmos 92923444+folmos-at-orange@users.noreply.github.com
Date: Wed Feb 19 15:30:32 2025 +0100
TODO Before Asking for a Review
dev(ormainfor release PRs)Unreleasedsection ofCHANGELOG.md(no date)