Closed
Conversation
TODO:
- update samples.py accordingly (work around the absence of results_dir)
- update sklearn/{estimators,dataset}.py
- update samples_sklearn.py
- for most functions, the results_dir positional parameter is replaced with specific parameters requiring full file paths; if directories are specified instead, then deprecation warning is issued and default file name as used in the GUI is concatenated to this dir. - for simplify_coclustering, the simplified_coclustering_file_path positional parameter was already present, along with results_dir, which is now deprecated. Hence, special treatment is required when both parameters are present *and* simplified_coclustering_file_path is relative: it is concatenated to results_dir. If simplified_coclustering_file_path is absolute, then results_dir is ignored.
Also update scenario template to v11.
Also fix relevant API function.
These are not specific to the v11 migration, but had been missed in v10.
popescu-v
force-pushed
the
update-to-v11
branch
2 times, most recently
from
24edd79 to
6533214
Compare
However, what is deprecated, is the Sequence specification. Only sequences of data elements are kept, which should be directly convertible to NumPy arrays; if they are not, then the code fails.
…hers The regression model .kdic now always includes the baseline model. The other estimators' models now never include the baseline model. For this "MVP" beta, we keep track of the baseline model if present, but we currently ignore it, even for regression; thus, as before, only the SNB model is used in the estimators.
popescu-v
force-pushed
the
update-to-v11
branch
3 times, most recently
from
3a93696 to
9e56562
Compare
Indeed, as the file-based datasets have been dropped, there is no support for remote access in sklearn-based Khiops estimators.
popescu-v
force-pushed
the
update-to-v11
branch
from
c46b277 to
8632bc6
Compare
popescu-v
force-pushed
the
update-to-v11
branch
from
8632bc6 to
35e417d
Compare
folmos-at-orange
requested changes
Mar 11, 2025
Member
folmos-at-orange
left a comment
folmos-at-orange
left a comment
There was a problem hiding this comment.
Last commit reviewed Set KHIOPS_API_MODE to "true"...
tests/resources/scenario_generation/api/simplify_coclustering/ref/Adult._kh
Show resolved
Hide resolved
Collaborator
Author
|
Superseded by #367: commit restructuring, squashing, re-ordering, for a cleaner history. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #325
TODO Before Asking for a Review
dev(ormainfor release PRs)khiops-python-tutorialrepo notebooks need to be updated with the v11 changes (to be done after the current beta release)[ ] When adding a public feature/fix: Update theTo be done in a distinct PR, in a subsequent RC pre-releaseUnreleasedsection ofCHANGELOG.md(no date)API Docs (only if there are changes in docstrings, rst files or samples):[ ] Check the docs build without warning: see the log of the API Docs workflow[ ] Check that your changes render well in HTML: download the API Docs artifact and openindex.htmlIf there are any problems it is faster to iterate by building locally the API DocsCannot be done: the Python tutorials need to be updated first.