Rename variable_part_dimensions to inner_variable_dimensions in Coclustering results#568
Open
Rename variable_part_dimensions to inner_variable_dimensions in Coclustering results#568
variable_part_dimensions to inner_variable_dimensions in Coclustering results#568Conversation
popescu-v
reviewed
Mar 25, 2026
| CoclusteringDimension | ||
| |- parts -> list of CoclusteringDimensionPart | ||
| |- variable_part_dimensions -> list of CoclusteringDimension | ||
| |- inner_variable_dimensions -> list of CoclusteringDimension |
Collaborator
There was a problem hiding this comment.
Shift all arrows one space to the right to keep them aligned.
popescu-v
reviewed
Mar 25, 2026
khiops/core/coclustering_results.py
Outdated
| inner_variable_dimensions : list of `CoclusteringDimension` | ||
| Variable part instance-variable coclustering dimensions. ``None`` for | ||
| variable-variable clustering. | ||
| This list is filled only in an "Instance * Variables coclustering" context. |
Collaborator
There was a problem hiding this comment.
I would replace all this paragraph with (to check with @marcboulle):
"""
Contains the dimensions of the variable parts of each variable as computed via the individual * variable coclustering algorithm.
"""
Collaborator
Author
There was a problem hiding this comment.
Thank you for the reformulation. I'm waiting for @marcboulle suggestion but it the meantime I put yours.
Collaborator
Author
There was a problem hiding this comment.
Marc validates but wants to add a precision. I put this later version.
popescu-v
requested changes
Mar 25, 2026
Collaborator
popescu-v
left a comment
popescu-v
left a comment
There was a problem hiding this comment.
Two docstring changes (see the comments).
tramora
force-pushed
the
552-refactor-coclustering-inner-variables
branch
from
5d917d5 to
ae8ee70
Compare
…oclustering results - `test_coclustering_results_simple_initializations` remains unchanged - the `CoclusteringDimension` docstring is amended to give more details on "Instances x Variables Coclustering"
tramora
force-pushed
the
552-refactor-coclustering-inner-variables
branch
from
ae8ee70 to
6ddf11a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_coclustering_results_simple_initializationsremains unchangedCoclusteringDimensiondocstring is amended to give more details on "Instance * Variables Coclustering"Fixes #552
The docstring amendment in
CoclusteringDimensionforinner_variable_dimensionsis far from perfect and may need correctionTODO Before Asking for a Review
main(ormain-v10)Unreleasedsection ofCHANGELOG.md(no date)index.html