Add CoclusteringCell part_indexes attribute for getting per-cell part indexes

[popescu-v]

The CoclusteringCell.part_indexes attribute is initialized from the cellPartIndexes JSON attribute directly.

closes #569.

---

TODO Before Asking for a Review

• Rebase your branch to the latest version of main (or main-v10)
• Make sure all CI workflows are green
• When adding a public feature/fix: Update the Unreleased section of CHANGELOG.md (no date)
• Self-Review: Review "Files Changed" tab and fix any problems you find
• API Docs (only if there are changes in docstrings, rst files or samples):
  • Check the docs build without warning: see the log of the API Docs workflow
  • Check that your changes render well in HTML: download the API Docs artifact and open index.html
  • If there are any problems it is faster to iterate by building locally the API Docs

[marcboulle]

Je ne comprend pas les propositions, qui ne répondent pas simplement au besoin exprimé.
Le fichier json contient des informations selon un format le plus simple possible à exploiter, et les classes python devraient juste être un wrapper minimaliste, permettant de retrouver simplement les information du json, avec éventuellement des helpers.

En l'occurrence, il me semble que le seul ajout a effectuer est d'ajouter l'accès à cellPartIndexespar cellules, via le nouvel attribut part_indexes, l'attribut existant parts ayant un rôle de helper pour accéderr directement aux objets concernés.

class CoclusteringCell:
    """A coclustering cell

    .. note::
        This class has only a no-parameter constructor initializing an instance with the
        default values.

    Attributes
    ----------
    part_indexes : list of int
        Part indexes for each dimension of the coclustering.
    parts : list of `CoclusteringDimensionPart`
        Parts for each dimension of the coclustering, associated with the corresponding indexes. 
    frequency : int
        Frequency of this cell.
    """

[popescu-v]

Je ne comprend pas les propositions, qui ne répondent pas simplement au besoin exprimé. Le fichier json contient des informations selon un format le plus simple possible à exploiter, et les classes python devraient juste être un wrapper minimaliste, permettant de retrouver simplement les information du json, avec éventuellement des helpers.

En l'occurrence, il me semble que le seul ajout a effectuer est d'ajouter l'accès à cellPartIndexespar cellules, via le nouvel attribut part_indexes, l'attribut existant parts ayant un rôle de helper pour accéderr directement aux objets concernés.

class CoclusteringCell:
    """A coclustering cell

    .. note::
        This class has only a no-parameter constructor initializing an instance with the
        default values.

    Attributes
    ----------
    part_indexes : list of int
        Part indexes for each dimension of the coclustering.
    parts : list of `CoclusteringDimensionPart`
        Parts for each dimension of the coclustering, associated with the corresponding indexes. 
    frequency : int
        Frequency of this cell.
    """

Ok, it seems simpler indeed to just add a CoclusteringCell.part_indexes attribute and initialize it in CoclusteringReport.__init__ when the CoclusteringCell instances are created and initialized.

[marcboulle]

LGTM

[tramora]

Looks good for me but is it possible to add the case in the automated test in test_core.py : test_coclustering_results_accessors

[popescu-v]

Looks good for me but is it possible to add the case in the automated test in test_core.py : test_coclustering_results_accessors

In the latest update there are no more accessors related to the scope of the PR. It's just an attribute that is being initialized directly from the JSON file.
The correct initialization of this attribute is indirectly tested via the CoclusteringReport.to_dict method which uses the attribute and is called in the CoclusteringResults.to_dict method, which is called in the CoclusteringResults.write_khiops_json_file method, which is tested in the KhiopsCoreIOTests._assert_coclustering_report_is_written_to_sorted_json_file method, which is called in the KhiopsCoreIOTests.test_coclustering_results testing method.