Skip to content

Improve security: protect password and add trusted value comments #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
assisted-by-ai wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve security: protect password and add trusted value comments #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions usr/bin/mw-edit
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ fi
## Need to create wiki tag mediawiki-shell here:
## https://www.whonix.org/wiki/Special:Tags

## edit_msg is a trusted value: either the hardcoded default or operator-supplied via CLI.
Copy link
Copy Markdown

@ArrayBolt3 ArrayBolt3 Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a useful comment.

curl_run \
"${curl_opts[@]}" \
--cookie "$cookie_jar" \
Expand Down
1 change: 1 addition & 0 deletions usr/bin/mw-flagged-revisions-approve-page
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ comment="mediawiki-shell-bot-flagged-revisions-mass-approve"

log info "Requesting review-result... ${TMPFOLDER}/review-result.json"

## comment is a trusted value: hardcoded in this script.
Copy link
Copy Markdown

@ArrayBolt3 ArrayBolt3 Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a useful comment.

curl_run \
"${curl_opts[@]}" \
--cookie "$cookie_jar" \
Expand Down
1 change: 1 addition & 0 deletions usr/bin/mw-multi-wiki
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ fi

mw-login-test "$default_wiki_url_target"

## multiwiki_category is a trusted value: either the hardcoded default or operator-supplied via CLI.
Copy link
Copy Markdown

@ArrayBolt3 ArrayBolt3 Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a useful comment.

all_pages="$(
curl_run \
"${curl_opts[@]}" \
Expand Down