feat: Add short sha to VersionContext Result#82
Conversation
asci13
changed the title
|
@Kieranties as promised :) Please take a look (especially the property naming) and let me know what to change. |
|
@asci13 Seems to be a 'quirk' with Azure Devops that the PR does not have access to to the artifacts to download simpleversion. Seems the build is ran as you as the user, and you don;t have permissions to the internal feed. I assumed the build ran as the build service user. Will address this shortly. |
Kieranties
left a comment
Kieranties
left a comment
There was a problem hiding this comment.
@asci13 Could you add some info to https://github.com/Kieranties/SimpleVersion/blob/master/docs/articles/results.md ?
One minor thing to check out, otherwise looks good! Should be able to complete pending docs.
|
@asci13 I've updated the build to pull simpleversion from nuget for builds. However, Azure devops doesn't appear to be using the change for the PR. You'll need to rebase your work on master and update the PR :-( |
|
@Kieranties all done now i hope :) |
Kieranties
left a comment
Kieranties
left a comment
There was a problem hiding this comment.
@asci13 Thanks! I'm still not certain about the usage of sha7 vs shortsha and can't find consistent usage of either term in other git solutions. I'll take this as is now, but may address the language before a v0.2 release.
|
@asci13 Shipped. You'll find the assets available on nuget.org soon. In the mean time: https://github.com/Kieranties/SimpleVersion/releases/tag/v0.2.0-alpha1.25 |
|
@Kieranties no stress with the artifacts, just wanted to contribute :) |
2 participants
Description
Added Sha7 (instead of ShortSha - afaik thats one of the official names of it) to the Result object.
Let me know if you'd prefer ShortSha instead.
Fixes #76
Change Type
Quality