refactor(web-components): escape innerHTML, add event cleanup, improve ARIA#18
Merged
Killea merged 1 commit intoKillea:mainfrom Mar 1, 2026
Merged
Conversation
…e ARIA - acb-filter-row.js: escape status attribute and text content in innerHTML (XSS prevention) - acb-agent-status-item.js: escape state and offlineDisplay in innerHTML (were raw strings) - acb-icon-button.js: add constructor + disconnectedCallback to remove click listener on teardown - acb-thread-item.js: add role=listitem and aria-current for active state; escape status badge - acb-thread-context-menu.js: add role=menu and role=menuitem on all action buttons for accessibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security, memory, and accessibility improvements across all Web Components.
Changes
XSS prevention — escape user-controlled values in innerHTML
�cb-filter-row.js
�cb-agent-status-item.js
�cb-thread-item.js
Memory leak prevention — disconnectedCallback for event cleanup
�cb-icon-button.js
emoveEventListener when the element is removed from DOM
Accessibility — ARIA roles
�cb-thread-item.js
ole='listitem' on each thread item
�cb-thread-context-menu.js
ole='menu' on the menu container
ole='menuitem' on all four action buttons
Tests