feat(ui): reply-quote jump navigation + thread creation fix (UI-13, UI-14)#40
Merged
Killea merged 6 commits intoKillea:mainfrom Mar 4, 2026
Merged
Conversation
Clickable reply-quote badge that scrolls to the referenced message with a transient highlight effect. - Add data-msg-id attribute to each message row - Replace div.msg-reply-quote with button[data-reply-target] (no inline onclick) - Add window.AcbScrollToMsg + event delegation on #messages - Add CSS reset for button.msg-reply-quote + .msg-jump-highlight outline
…one-shot flag per thread)
…t-area in shared-chat.js selectThread, revert one-shot flag (aria-expanded guard is sufficient)
- Auto-register a browser-session agent (sessionStorage) to obtain X-Agent-Token required by POST /api/threads - Pass creator_agent_id + X-Agent-Token header when creating thread - Fix shared-api.js headers merge (spread was overwriting Content-Type) - Disable Create button when topic is empty; re-enable on input - Add .btn-primary:disabled CSS style
…valents In JS comments and string literals, replace: - U+2014 em dash with ASCII '--' - U+2026 ellipsis with HTML entity … Prevents double-encoding issues consistent with project conventions (PR Killea#38).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UI-13 -- Reply-quote jump navigation
When a message has a
reply_to_msg_id, thediv.msg-reply-quoteis now a clickable<button>that scrolls precisely to the referenced message and briefly highlights it.Changes:
index.html:div.msg-reply-quote->button[data-reply-target]withdata-msg-idon each message rowindex.html:window.AcbScrollToMsg()usesscrollEl.scrollTo({ top: offsetTop - 12 })(same logic as nav minimap)index.html: event delegation on#messagescontainer (no inline onclick)main.css: button reset styles for.msg-reply-quote+.msg-jump-highlightoutline animationFix -- sys-prompt visibility on thread switch
selectThread()inshared-chat.jswas not clearing#sys-prompt-areabefore loading a new thread. The deduplication check onseq=0found the previous thread's system prompt in the DOM and skipped rendering the new one, leaving the area empty.Fix: Clear
sysPromptAreaEl.innerHTMLat the start ofselectThread().UI-14 -- Thread creation from UI modal
POST /api/threadsrequiresX-Agent-Token+creator_agent_id. The modal was not providing these, causing a silent 401 and no thread appearing after clicking Create.Changes:
shared-ui-agent.js(new): auto-registers aui-humanbrowser-session agent on first call, caches token insessionStorageshared-modals.js:submitThreadModal()fetches the session token and passes it asX-Agent-Tokenheader +creator_agent_idshared-api.js: fix headers merge (...optionsspread was silently overwritingContent-Type)acb-modal-shell.js: Create button hasdisabledby default; enabled reactively viainputlistener on the topic fieldmain.css:.btn-primary:disabledstyle (opacity 0.4, cursor not-allowed)Encoding
All new lines are ASCII-only. Unicode characters (U+2014, U+2026) replaced with
--/…to match project conventions from PR #38.Test plan