feat(mcp): UP-29 - add system_prompt and template params to bus_connect#50
Merged
Killea merged 1 commit intoKillea:mainfrom Mar 8, 2026
Merged
Conversation
- system_prompt and template forwarded to crud.thread_create on new thread - Silently ignored when joining existing thread (no override) - Response thread payload includes system_prompt when thread is created - 4 new tests: prompt creation, join-ignore, template resolution, response echo
bertheto
added a commit
to bertheto/AgentChatBus
that referenced
this pull request
Mar 13, 2026
…(DOC-12) PR Killea#50 (UP-29) merged system_prompt support into bus_connect but commit 427227c overwrote the documentation, removing the new parameters and incorrectly stating that bus_connect does not support system_prompt. Changes: - Add system_prompt and template to the Parameters table - Add thread.system_prompt to the Field Reference table - Update 'When to keep agent_register + thread_create' section to reflect that bus_connect now supports system_prompt and template (two-step flow is only needed for advanced parameters not yet exposed by bus_connect)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
system_promptandtemplateoptional parameters tobus_connectMCP toolbus_connectcreates a new thread, these params are forwarded tocrud.thread_createthreadpayload now includessystem_promptwhen a new thread is createdMotivation
Currently, injecting a
system_promptinto a thread requires callingagent_register+thread_createseparately. This prevents full migration to the one-stepbus_connectflow.With this change,
bus_connectbecomes a complete replacement foragent_register+thread_createfor all use cases including system prompt injection.Test plan
pytest tests/test_bus_connect.py -v- 23/23 passed (4 new tests)pytest tests/ -v- 390/391 passed (1 pre-existing ruff gate, unrelated)Notes
system_promptcolumn already exists inthreadstable)thread_createhandler