Conversation
- Automatically moved in to frame. Will flip side to fit, and even scroll up/down if you scroll - Allows newlines, with pretty formatting
Fix our tooltip!
Multi select should stay open allowing you to... multi select
taller input for plaintext
Strip whitespace from descriptions of tools
Tasks as tools link updates
Added missing breadcrumbs
Run page ux improvement
Tools selector properly multiple tool sets of same type
…ys-there-on-project-switch fix: rag store does not clear on project switch
Update our intro.
Add GLM 4.6
Add agents to readme
…ce-changed-broke-ragtool fix: kiln tool interface run method change
…and-glm-45v feat: add GLM 4.5V extractor
Contributor
|
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 37 files out of 145 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📊 Coverage ReportOverall Coverage: 92% Diff: origin/docs...HEAD
Summary
Line-by-lineView line-by-line diff coverageapp/desktop/studio_server/settings_api.pyLines 39-53 39 raise HTTPException(status_code=500, detail=str(e))
40
41 @app.post("/api/open_project_folder/{project_id}")
42 def open_project_folder(project_id: str):
! 43 try:
! 44 project = project_from_id(project_id)
! 45 path = project.path
! 46 if not path:
! 47 raise HTTPException(status_code=500, detail="Project path not found")
48
! 49 open_folder(path)
! 50 return {"message": "opened"}
! 51 except Exception as e:
! 52 raise HTTPException(status_code=500, detail=str(e))app/desktop/studio_server/tool_api.pyLines 608-616 608 _validate_kiln_task_tool_task_and_run_config(project_id, tool_data)
609
610 existing_tool_server = tool_server_from_id(project_id, tool_server_id)
611 if existing_tool_server.type != ToolServerType.kiln_task:
! 612 raise HTTPException(
613 status_code=400,
614 detail="Existing tool server is not a kiln task tool. You can't edit a non-kiln task tool with this endpoint.",
615 )libs/core/kiln_ai/datamodel/basemodel.pyLines 613-621 613 # Note: we're using the in-file ID. We could make this faster using the path-ID if this becomes perf bottleneck, but it's better to have 1 source of truth.
614 for child_path in cls.iterate_children_paths_of_parent_path(parent_path):
615 child_id = ModelCache.shared().get_model_id(child_path, cls)
616 if child_id in ids:
! 617 children[child_id] = cls.load_from_file(child_path)
618 if child_id is None:
619 child = cls.load_from_file(child_path)
620 if child.id in ids:
621 children[child.id] = childlibs/core/kiln_ai/datamodel/external_tool_server.pyLines 107-116 107 self._unsaved_secrets[key_name] = env_vars[key_name]
108 # Remove from env_vars immediately so they are not saved to file
109 del env_vars[key_name]
110
! 111 case ToolServerType.kiln_task:
! 112 pass
113
114 case _:
115 raise_exhaustive_enum_error(self.type)Lines 262-272 262 validate_return_dict_prop(
263 properties, "run_config_id", str, err_msg_prefix
264 )
265
! 266 case _:
267 # Type checking will catch missing cases
! 268 raise_exhaustive_enum_error(server_type)
269 return data
270
271 @model_validator(mode="before")
272 def validate_headers_and_env_vars(cls, data: dict) -> dict:Lines 276-284 276 type = ExternalToolServer.type_from_data(data)
277
278 properties = data.get("properties", {})
279 if properties is None:
! 280 raise ValueError("properties is required")
281
282 match type:
283 case ToolServerType.remote_mcp:
284 # Validate headersLines 309-317 309 case ToolServerType.kiln_task:
310 pass
311
312 case _:
! 313 raise_exhaustive_enum_error(type)
314
315 return data
316
317 def get_secret_keys(self) -> list[str]:libs/core/kiln_ai/datamodel/tool_id.pyLines 73-81 73 # Kiln task tools must have format: kiln_task::<server_id>
74 if id.startswith(KILN_TASK_TOOL_ID_PREFIX):
75 server_id = kiln_task_server_id_from_tool_id(id)
76 if not server_id:
! 77 raise ValueError(
78 f"Invalid Kiln task tool ID: {id}. Expected format: 'kiln_task::<server_id>'."
79 )
80 return idlibs/core/kiln_ai/tools/mcp_session_manager.pyLines 194-202 194 # Read stderr content from temporary file for debugging
195 err_log.seek(0) # Read from the start of the file
196 stderr_content = err_log.read()
197 if stderr_content:
! 198 logger.error(
199 f"MCP server '{tool_server.name}' stderr output: {stderr_content}"
200 )
201
202 # Check for MCP errors. Things like wrong arguments would fall here.Lines 213-221 213 """
214 error_msg = f"'{e}'"
215
216 if stderr:
! 217 error_msg += f"\nMCP server error: {stderr}"
218
219 error_msg += f"\n{LOCAL_MCP_ERROR_INSTRUCTION}"
220
221 raise RuntimeError(error_msg) from elibs/core/kiln_ai/utils/filesystem.pyLines 4-15 4 from pathlib import Path
5
6
7 def open_folder(path: str | Path) -> None:
! 8 dir = os.path.dirname(path)
9 if sys.platform.startswith("darwin"):
! 10 subprocess.run(["open", dir], check=True)
11 elif sys.platform.startswith("win"):
! 12 os.startfile(dir) # type: ignore[attr-defined]
13 else:
! 14 subprocess.run(["xdg-open", dir], check=True)libs/server/kiln_server/server.pyLines 16-25 16 def _get_version() -> str:
17 """Get the version of the kiln-server package."""
18 try:
19 return version("kiln-server")
! 20 except Exception:
! 21 return "unknown"
22
23
24 def make_app(lifespan=None):
25 app = FastAPI(
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.