feat(cloud-agent-next): enable tracing in observability config#1058
Merged
feat(cloud-agent-next): enable tracing in observability config#1058
Conversation
Update the observability block in wrangler.jsonc to enable traces and persistent logs with head_sampling_rate=1, while keeping the top-level observability.enabled flag false so the full pipeline can be activated in a controlled rollout.
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| }, | ||
| "observability": { | ||
| "enabled": true, | ||
| "enabled": false, |
Contributor
Author
There was a problem hiding this comment.
WARNING: Top-level observability is still disabled
With "enabled": false, Cloudflare ignores the nested logs and traces settings, so this config will not actually turn on tracing for the worker. If the goal of this PR is to enable request traces and persisted logs, this line needs to stay true.
Suggested change
| "enabled": false, | |
| "enabled": true, |
Contributor
Author
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Other Observations (not in diff)None. Files Reviewed (1 files)
Fix these issues in Kilo Cloud Reviewed by gpt-5.4-20260305 · 200,945 tokens |
eshurakov
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update the
observabilityblock incloud-agent-next/wrangler.jsoncto configure tracing and persistent logs. The top-levelobservability.enabledremainsfalseso the full pipeline can be activated in a controlled rollout, whiletracesandlogssub-sections are individually enabled withhead_sampling_rate: 1andpersist: true.Verification
Visual Changes
N/A
Reviewer Notes
The top-level
enabled: falsemeans observability won't fully activate until it's flipped totrue. Thetracesandlogssub-sections are pre-configured so that when the top-level flag is enabled, tracing and log persistence will immediately take effect at full sampling rate.