fix(auth): pass callbackPath through magic link sign-in flow#1318
Merged
Conversation
The callbackPath URL parameter was dropped when users chose the magic link sign-in method. OAuth flows correctly threaded it via getSignInCallbackUrl(params), but handleSendMagicLink only sent the email. The backend already supported callbackUrl end-to-end — the only gap was the frontend never sending it.
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Reviewed by gpt-5.4-20260305 · 145,720 tokens |
jeanduplessis
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
callbackPathbeing dropped when users sign in via the magic link method. OAuth flows (Google, GitHub, WorkOS, etc.) correctly threadedcallbackPaththroughgetSignInCallbackUrl(params), buthandleSendMagicLinkonly sent the email address — ignoringparamsentirely.callbackUrlend-to-end (API route zod schema, email builder, magic link URL generator, verify-magic-link page). The only gap was the frontend never sending the value. This two-file change closes that gap.Verification
pnpm typecheck— passedpnpm lint(via pre-commit hook) — passedpnpm format:check(via pre-commit hook) — passed/users/sign_in?callbackPath=/organizations/new, clicked "Continue with Email", confirmed flow reaches Turnstile with callbackPath still in the URL context (Turnstile challenge blocked full end-to-end automated test)Visual Changes
N/A
Reviewer Notes
useSignInFlow.tshandlescallbackPath— viagetSignInCallbackUrl(params)./api/auth/magic-link),sendMagicLinkEmail,getMagicLinkUrl, andverify-magic-linkpage all already accepted and forwardedcallbackUrl. Only the client-side call site was missing it.paramswas added to theuseCallbackdependency array forhandleSendMagicLinksince it now reads from it.