fix(models): exclude gemini-3.1-pro-preview from models/up health check#2404
Merged
markijbema merged 1 commit intomainfrom Apr 14, 2026
Merged
fix(models): exclude gemini-3.1-pro-preview from models/up health check#2404markijbema merged 1 commit intomainfrom
markijbema merged 1 commit intomainfrom
Conversation
introduce HEALTH_CHECK_EXCLUSIONS and apply filter to monitored models
Contributor
Author
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 files)
Reviewed by gpt-5.4-20260305 · 132,893 tokens |
RSO
approved these changes
Apr 14, 2026
chrarnoldus
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reintroduces the health-check exclusion for
google/gemini-3.1-pro-previewfrom #2388, which was lost during a subsequent change. The preview model has inconsistent traffic that causes false alerts in/api/models/up. The exclusion is scoped to the health-check route only — the model remains inpreferredModelsand is still marked as recommended.Verification
pnpm format— passed, no formatting changespnpm typecheck— no new errors introducedpreferredModelsinmodels.tsis unchangedVisual Changes
N/A
Reviewer Notes
The exclusion is implemented as a
Set(HEALTH_CHECK_EXCLUSIONS) so additional models can easily be excluded in the future without touchingpreferredModels.