fix(auth): add web session pepper revocation#2788
Merged
Conversation
Contributor
Code Review SummaryStatus: 4 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Resolved previously reported issue:
Other Observations (not in diff)Issues found in unchanged code that cannot receive inline comments:
Files Reviewed (17 files)
Reviewed by gpt-5.4-20260305 · 1,724,588 tokens |
| @@ -0,0 +1,3 @@ | |||
| ALTER TABLE "kilocode_users" ADD COLUMN "web_session_pepper" text; | |||
| --> statement-breakpoint | |||
| UPDATE "kilocode_users" SET "web_session_pepper" = "api_token_pepper"; | |||
Contributor
There was a problem hiding this comment.
WARNING: Full-table backfill runs in one migration statement
This UPDATE rewrites every row in kilocode_users in a single deploy-time migration step. On a populated users table that can become a long-running backfill and hold locks for a while, so this is safer to batch or run out-of-band instead of doing it as one transaction-scoped migration statement.
jeanduplessis
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
web_session_pepperto user records so browser sessions can be invalidated independently from API tokens.Verification
Reviewer Notes
web_session_pepper.web_session_pepperis first rotated because legacy missing pepper values normalize tonull.