Skip to content

fix(kiloclaw): bind migrate-legacy arrays as text[]#2838

Merged
joshavant merged 1 commit intomainfrom
fix/kiloclaw-legacy-migration-array-bindings-clean
Apr 28, 2026
Merged

fix(kiloclaw): bind migrate-legacy arrays as text[]#2838
joshavant merged 1 commit intomainfrom
fix/kiloclaw-legacy-migration-array-bindings-clean

Conversation

@joshavant
Copy link
Copy Markdown
Contributor

Summary

  • Fix /api/controller/google/migrate-legacy writes to bind scopes and capabilities as explicit text[] SQL expressions instead of relying on raw array interpolation in sql templates.
  • Reuse the same safe array binding for all legacy migration update paths so capabilities updates cannot emit tuple-shaped SQL.
  • Add a regression test covering migration insert with empty scopes and empty capabilities to prevent 500 regressions on edge payloads.

Verification

  • Reviewed generated SQL construction in services/kiloclaw/src/routes/controller.ts and confirmed array writes now use explicit ARRAY[]::text[] / ARRAY[...]::text[] binding.
  • Reviewed all writes to kiloclaw_google_oauth_connections in this path to ensure array fields in migrate-legacy are handled consistently.

Visual Changes

  • N/A

Reviewer Notes

  • Risk is isolated to broker migration write paths in the KiloClaw worker.
  • This change targets the production failure mode where malformed array SQL caused migration_endpoint_failed due to server-side 500s.

Serialize scopes and capabilities with explicit text[] SQL in migrate-legacy writes so PostgreSQL array columns are bound correctly. Add coverage for empty scopes/capabilities on insert to prevent regressions.
@kilo-code-bot
Copy link
Copy Markdown
Contributor

kilo-code-bot Bot commented Apr 27, 2026

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (2 files)
  • services/kiloclaw/src/routes/controller.ts
  • services/kiloclaw/src/routes/controller.test.ts

@joshavant joshavant merged commit f744f9b into main Apr 28, 2026
15 of 16 checks passed
@joshavant joshavant deleted the fix/kiloclaw-legacy-migration-array-bindings-clean branch April 28, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants