feat(notifications,kilo-chat): PR 3 — notifications rewrite + push on message.created

[iscekic]

Summary

Third PR in the kilo-chat migration stack (Phases 3 and 5 of the plan). Rewires the notifications worker as a WorkerEntrypoint and wires kilo-chat to publish a push notification whenever a message is persisted.

Stacked on: #2914 (PR 2 — DB rename channel_badge_counts → badge_counts).

Notifications service (Phase 3)

• Adds EVENT_SERVICE service binding to the worker; drops STREAM_CHAT_API_SECRET.
• Adds vitest scaffold (config, setup, env types) with miniflare stubs for EVENT_SERVICE and a SELF self-binding for entrypoint RPC tests.
• Replaces NotificationChannelDO with a generic dispatchPush primitive: idempotency (1h TTL alarm-pruned), presence skip via EVENT_SERVICE.isUserInContext, token lookup, badge math, Expo dispatch, receipts queue. failed outcome leaves no idempotency key, so upstream can retry.
• Adds WorkerEntrypoint NotificationsService.sendPushForConversation (sender-exclude + dedupe + per-recipient DO fan-out) with a pure sendPushForConversationCore for unit testability.
• Drops the now-orphan badgeBucketForInstance helper from @kilocode/notifications (the rewritten DO no longer writes per-sandbox bucket rows).
• Deletes services/notifications/src/routes/webhooks.ts (Stream webhook gone).
• Layers RPC types onto EVENT_SERVICE binding and enables cloudflare:test types so pnpm typecheck is clean at HEAD.

Kilo-chat producer (Phase 5)

• Adds kiloclaw event-context builders (kiloclawInstanceContext, kiloclawConversationContext) to @kilocode/event-service; migrates event-push.ts to use them. Single source of truth shared by producers/consumers.
• Adds fetchSandboxLabel helper.
• Adds NOTIFICATIONS service binding (entrypoint: NotificationsService).
• After persisting a message.created, createMessageFor now fans out a push via NOTIFICATIONS.sendPushForConversation for non-sender human members. Failures are logged, never block the send.

⚠️ Stream webhook gap

Per the plan: deleting the Stream webhook route here means Stream messages stop generating push notifications during the soak window before PR 6's mobile cutover. Stream is being decommissioned anyway; flagging explicitly.

Test plan

• services/notifications: pnpm typecheck — clean
• services/notifications: pnpm test — 8/8 pass (dispatch-push + send-push-for-conversation)
• services/kilo-chat: pnpm typecheck — clean
• services/kilo-chat: pnpm test — 246/246 pass (incl. 3 new push-notifications cases: negative no-recipients, positive multi-human, failure isolation)
• packages/event-service: pnpm typecheck — clean

[kilo-code-bot]

Code Review Summary

Status: 2 Issues Found | Recommendation: Address before merge

Overview

Severity	Count
CRITICAL	0
WARNING	2
SUGGESTION	0

Fix these issues in Kilo Cloud

Issue Details (click to expand)

WARNING

File	Line	Issue
services/notifications/src/index.ts	49	Conversation-scoped badge buckets still cannot be cleared by the current mobile unread/read flow.
services/notifications/src/index.ts	56	Push payload shape still does not match the deployed mobile notification parser.

Other Observations (not in diff)

Issues found in unchanged code that cannot receive inline comments:

File	Line	Issue
N/A	N/A	None

Files Reviewed (1 file)

• packages/event-service/src/presence.ts - 0 new issues

Carried forward from previous review:

• services/notifications/src/index.ts - 2 accepted transitional mobile compatibility warnings.

---

_{Reviewed by gpt-5.5-2026-04-23 · 692,149 tokens}