Skip to content

fix(web): use uuid for client-generated ids#3698

Merged
iscekic merged 1 commit into
mainfrom
fix/web-client-uuid-generation
Jun 3, 2026
Merged

fix(web): use uuid for client-generated ids#3698
iscekic merged 1 commit into
mainfrom
fix/web-client-uuid-generation

Conversation

@iscekic
Copy link
Copy Markdown
Contributor

@iscekic iscekic commented Jun 3, 2026

Summary

  • Replaces browser crypto.randomUUID() calls in Cloud Agent, App Builder, and shared upload client code with the existing uuid package.
  • Keeps generated values as UUID v4 strings for attachment paths, upload item IDs, terminal tab IDs, and profile draft IDs while avoiding runtimes where crypto.randomUUID is unavailable.

Verification

N/A

Visual Changes

N/A

Reviewer Notes

  • Automated checks run locally: pnpm format, focused web upload tests, web typecheck, and git diff --check.
  • Full monorepo typecheck was skipped in favor of the targeted web package check.

@iscekic iscekic self-assigned this Jun 3, 2026
@iscekic iscekic requested a review from jeanduplessis June 3, 2026 12:58
@iscekic iscekic enabled auto-merge (squash) June 3, 2026 12:58
@iscekic iscekic requested a review from RSO June 3, 2026 12:58
@kilo-code-bot
Copy link
Copy Markdown
Contributor

kilo-code-bot Bot commented Jun 3, 2026

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

All 7 crypto.randomUUID() calls in client-side React components and hooks are correctly replaced with uuidv4() from the existing uuid package, using a consistent import pattern already established in the codebase.

Files Reviewed (7 files)
  • apps/web/src/components/app-builder/AppBuilderChat.tsx
  • apps/web/src/components/app-builder/AppBuilderLanding.tsx
  • apps/web/src/components/cloud-agent-next/CloudChatPage.tsx
  • apps/web/src/components/cloud-agent-next/NewSessionPanel.tsx
  • apps/web/src/components/cloud-agent/ProfilesListDialog.tsx
  • apps/web/src/hooks/useCloudAgentAttachmentUpload.ts
  • apps/web/src/hooks/useImageUpload.ts

Fix these issues in Kilo Cloud


Reviewed by claude-4.6-sonnet-20260217 · 340,476 tokens

Review guidance: REVIEW.md from base branch main

@RSO
Copy link
Copy Markdown
Contributor

RSO commented Jun 3, 2026

Ideally we'd have some type of compatibility layer in the lint rules that automatically detects these 🤔

@iscekic iscekic merged commit 1fb759d into main Jun 3, 2026
16 checks passed
@iscekic iscekic deleted the fix/web-client-uuid-generation branch June 3, 2026 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants