Cloud Agent - Filter child session events in event processor#603
Merged
Cloud Agent - Filter child session events in event processor#603
Conversation
Skip onSessionStatusChanged, onStreamingChanged, and streaming flag toggling for child/sub-agent sessions. This prevents consumers like the Slack bot from prematurely disconnecting when a child session emits idle while the parent session is still running. Child sessions still get user message completion and onError callbacks.
Contributor
Code Review SummaryStatus: 1 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Other Observations (not in diff)Issues found in unchanged code that cannot receive inline comments: None. Files Reviewed (2 files)
|
RSO
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
event-processor.tsso thatonSessionStatusChanged,onStreamingChanged, and thestreamingflag are only toggled by root session events.run-session.ts) from prematurely disconnecting when a child session emitsidlewhile the parent session is still running.onErrorcallbacks — only status/streaming propagation is suppressed.Changes
event-processor.tsisChildSession()helper using the existingsessionParentsmaphandleSessionStatus: skipsonSessionStatusChanged/onStreamingChangedfor child sessionshandleSessionIdle: accepts{ sessionID }param; skips streaming toggle for child sessionshandleSessionError: skips streaming toggle for child sessions;onErrorstill fires for allhandleSessionTurnClose: passesskipStreamingToggletoforceCompleteAllMessagesfor child sessionsforceCompleteAllMessages: accepts optionalskipStreamingToggleparameterevent-processor.test.tschild session event filteringdescribe block covering all filtering scenarios