Conversation
…re failure messages
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 files)
|
jeanduplessis
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
kilo-restore-session.jsfails, the structured stdout (containingstep,error, andcodefields) was logged locally inside the Durable Object but lost by the time the error propagated through the tRPC chain to logpush. The error message only said"Cold-start session restore failed: exit 1", making it impossible to diagnose failures from logpush alone.This change enriches the
SessionSnapshotRestoreErrormessage at the throw site to includestepanderrorfields extracted from the restore script's JSON stdout. The richer message flows naturally through the existing error chain (SessionSnapshotRestoreError→ExecutionError.workspaceSetupFailed→TRPCError) without any downstream changes.Before:
"Failed to prepare workspace: Cold-start session restore failed: exit 1"After:
"Failed to prepare workspace: Cold-start session restore failed: exit 1, step=import, error=kilo import failed exitCode=1"Verification
pnpm run typecheck— passed (tsgo + wrapper)pnpm run test— 642 tests passed, 25 test filestoThrow('Cold-start session restore failed')) and remain compatible with the enriched messageVisual Changes
N/A
Reviewer Notes
cloud-agent-next/src/session-service.ts— extends the existing stdout JSON parsing block (which already extractscode) to also extractstepanderror.as Record<string, unknown>cast onJSON.parsematches the existing pattern at this location.