Delete unsupported parameter for Grok Code Fast 1#980
Merged
chrarnoldus merged 1 commit intomainfrom Mar 10, 2026
Merged
Conversation
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| extraHeaders: Record<string, string> | ||
| ) { | ||
| if (requestedModel === grok_code_fast_1_optimized_free_model.public_id) { | ||
| delete requestToMutate.reasoning; |
Contributor
There was a problem hiding this comment.
WARNING: This silently disables reasoning for a model that still advertises reasoning support.
grok_code_fast_1_optimized_free_model still has the reasoning flag, and convertFromKiloModel() derives supported_parameters from that flag, so clients will continue offering reasoning for this model even though the request drops it here. That creates an API-contract mismatch where a user can select thinking mode and get instant mode with no signal.
Contributor
Author
There was a problem hiding this comment.
It is a reasoning model, it's just not configurable.
Contributor
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Other Observations (not in diff)None. Files Reviewed (2 files)
|
imanolmzd-svg
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://kilo-code.slack.com/archives/C0A509PREAU/p1773143363588879
https://kilo-code.slack.com/archives/C08TXA9QAGP/p1773141976913499