Skip to content

Agent Manager: Review comment edit button doesn't work #7585

@marius-kilocode

Description

@marius-kilocode

Bug Description

When adding comments as part of a review in the Agent Manager, the edit button doesn't do anything. Users have to delete the comment and re-add it.

Root Cause

The editing signal is updated when the edit button is clicked, but the annotation rendering pipeline never re-triggers.

The click handler at webview-ui/agent-manager/review-annotations.ts:237 correctly calls setEditing(comment.id), but annotationsForFile in DiffPanel.tsx:244 only depends on commentsByFile() and draft() — it does not read editing(). Since the annotations array passed to <Diff> never changes, pierre (the diff rendering library) never re-renders the annotation, so the textarea never appears.

The same bug exists in FullScreenDiffView.tsx.

Steps to Reproduce

  1. Open the Agent Manager and navigate to a session's diff review
  2. Add a comment on a diff line
  3. Click the edit button on the comment
  4. Nothing happens — the comment stays in display mode

Expected Behavior

Clicking the edit button should switch the comment to edit mode (showing a textarea with the comment text).

Workaround

Delete the comment and add it again.

Fix Direction

Include the editing state in the annotations' reactive dependency chain so pierre detects the change and re-renders the annotation in edit mode.

Environment

Reported on remote SSH (Windows to Linux).

Metadata

Metadata

Assignees

No one assigned

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions