fix: constrain Kilo indexing embedding models#10619
Merged
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge OverviewIncremental review performed. The previous commit The PR correctly implements a
Files Reviewed (21 files)
Reviewed by claude-4.6-sonnet-20260217 · 1,075,392 tokens Review guidance: REVIEW.md from base branch |
chrarnoldus
approved these changes
May 27, 2026
5bbaddb to
33a270e
Compare
3a120d9 to
117691e
Compare
Collaborator
Author
|
Removed all the unrelated changes... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Semantic indexing through Kilo is a managed path: Kilo defines the supported hosted embedding models and their compatible defaults. Exposing a free-text Kilo model override was redundant and could leave stale or unsupported model IDs configured.
This restricts Kilo indexing to hosted presets in VS Code and the CLI, and validates stored Kilo model IDs before runtime use. Custom model strings remain available for local and external providers through the normal custom-model input.
Provider or hosted-preset changes persistently reset obsolete model and dimension overrides, so an old Kilo model or incompatible vector dimension is not silently carried into the next selection.