-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix(cli): keep API request cost updates visible without flicker #4792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 17a763b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ No Issues Found7 files reviewed | Confidence: 95% | Recommendation: Merge Review DetailsFiles:
Checked: Security, bugs, performance, error handling Analysis:
|
✅ No Issues Found7 files reviewed | Confidence: 95% | Recommendation: Merge Review DetailsFiles Reviewed:
Summary: Key Changes:
Checked: Security, bugs, performance, error handling, test coverage Notes:
|
Fixes a #4718 side-effect where
api_req_started(non-partial placeholders) could be frozen into Ink<Static>without costs, and later cost updates would either never appear or show up out-of-order/duplicated.Changes:
api_req_startedwithout completion indicators in the dynamic tail so it can update in-place once cost/cancel/failure arrives.Includes tests and a changeset.
During requests API requests will now show like this in the CLI:

Once the cost info is available we update the static UI component in place to look like this: