Conversation
This reverts commit 98b3340.
This reverts commit 546748a.
The stale-issues workflow was hitting the default 30 operations limit, preventing it from processing all 2900+ issues/PRs. Increased to 1000 to handle the full backlog. Also pinned to exact v10.2.0 for reproducibility.
- Create script/github/close-issues.ts to close stale issues after 60 days - Add GitHub Action workflow to run daily at 2 AM - Remove old stale-issues workflow to avoid conflicts
- Add contents: read permission for checkout - Use github.token instead of secrets.GITHUB_TOKEN
…f instance is global) (#19058)
This reverts commit a379eb3.
This reverts commit cbe1337.
This reverts commit 898456a.
| directory: ctx.directory, | ||
| headers: Flag.KILO_SERVER_PASSWORD | ||
| ? { | ||
| Authorization: `Basic ${Buffer.from(`${Flag.KILO_SERVER_USERNAME ?? "opencode"}:${Flag.KILO_SERVER_PASSWORD}`).toString("base64")}`, |
There was a problem hiding this comment.
WARNING: Default basic-auth username no longer matches the server
Server.ControlPlaneRoutes() now falls back to Flag.KILO_SERVER_USERNAME ?? "kilo", but this client still falls back to "opencode". If a user sets only KILO_SERVER_PASSWORD, internal plugin requests sent through client will authenticate with the wrong credentials and start failing with 401s.
| function rewrite(request: Request, directory?: string) { | ||
| if (request.method !== "GET" && request.method !== "HEAD") return request | ||
|
|
||
| const value = pick(request.headers.get("x-opencode-directory"), directory) |
There was a problem hiding this comment.
WARNING: The GET/HEAD rewrite still looks for the old header name
createKiloClient() now sets x-kilo-directory, but rewrite() only reads and deletes x-opencode-directory. As a result, v1 SDK GET/HEAD requests never move directory into the query string, so the new query-parameter routing path is effectively broken.
| let changed = false | ||
|
|
||
| for (const [name, key] of [ | ||
| ["x-opencode-directory", "directory"], |
There was a problem hiding this comment.
WARNING: Header rewriting still uses the pre-rename x-opencode-* keys
This client now writes x-kilo-directory and x-kilo-workspace, so this loop never finds either value. GET/HEAD requests therefore skip rewriting both directory and workspace into query params, which breaks the new workspace-aware routing path in the v2 SDK.
Code Review SummaryStatus: 4 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Other Observations (not in diff)No additional high-confidence issues found outside the diff. Files Reviewed (32 files)
Reviewed by gpt-5.4-20260305 · 894,037 tokens |
| state.skills[skill.name] = { | ||
| name: skill.name, | ||
| description: skill.description, | ||
| location: BUILTIN_LOCATION, |
There was a problem hiding this comment.
WARNING: Built-in skills now advertise a fake filesystem location
These new entries store location: "builtin", but Skill.fmt(..., { verbose: true }) still runs pathToFileURL(skill.location) for every skill. That means the <available_skills> block shown to the agent will emit a bogus file://.../builtin URL instead of preserving the built-in marker, so built-in skills can be misidentified as real on-disk skills.
…nd PopupSelector Normalize boolean expression indentation in isCompletionResult to use consistent 4-space alignment and reformat PopupSelectorProps generic interface declaration to split the Omit type across multiple lines.
Remove outdated URLs and add new bug report issue link pointing to anomalyco/opencode repository. Drop references to kilocode bug report template and config precedence order docs, reducing total unique URLs from 262 to 261.
Drop the NerdFonts story from font.stories.tsx along with the unused MONO_NERD_FONTS import, as the exported constant is no longer available from the @opencode-ai/ui/font module.
…arding Relocate the Show component to wrap the box element instead of being nested inside it, preventing the empty box from rendering when the onboarding tip is not visible.
Core
TUI
Desktop