Conversation
Reviewer's GuideAdds contributor documentation and curated configuration docs, wires them into the MkDocs navigation, and updates the README to link prominently to the hosted documentation and new guides. Flow diagram for navigating updated documentation linksflowchart TD
A[GitHub README] --> B[Docs badge link]
A --> C[Documentation link in Table of Contents]
B --> D[Docs home page]
C --> D
D --> E[Installation Guide]
D --> F[Configuration Guide]
D --> G[Pre-defined Configs]
D --> H[Pre-commit Guide]
D --> I[CI Integration Guide]
D --> J[Troubleshooting]
D --> K[API Reference]
D --> L[Contributing page]
E --> A1[Install ruff-sync]
F --> A2[Configure ruff-sync in pyproject.toml]
G --> A3[Choose curated Ruff configuration]
H --> A4[Integrate with pre-commit]
I --> A5[Add check command to CI pipeline]
J --> A6[Resolve common issues]
K --> A7[Use programmatic API]
L --> A8[Follow contribution workflow]
Flow diagram for contributing a curated Ruff configurationflowchart TD
A[Read Pre-defined Configs doc] --> B[Decide to contribute new config]
B --> C[Read Contributing docs]
C --> D[Join discussion on Issue 83]
D --> E[Agree on scope and domain]
E --> F[Create configs/my-domain directory]
F --> G[Add ruff.toml with inline comments]
G --> H[Optionally add README explaining goals]
H --> I[Run quality checks and tests]
I --> J[Commit and push branch]
J --> K[Open PR referencing Issue 83]
K --> L[Address review feedback]
L --> M[Config merged and available as curated option]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
|
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="docs/pre-defined-configs.md" line_range="46" />
<code_context>
+
+## 📊 Data Science & Engineering
+
+Optimized for data science workflows, focusing on readability and common patterns found in Jupyter notebooks, pandas, and numpy code.
+
+### Key Features
</code_context>
<issue_to_address>
**nitpick (typo):** Consider capitalizing "NumPy" as a proper name.
This also keeps capitalization consistent with nearby proper names like Jupyter and pandas, and matches common usage in the docs.
Suggested implementation:
```
Optimized for data science workflows, focusing on readability and common patterns found in Jupyter notebooks, pandas, and NumPy code.
```
If there are other occurrences of "numpy" used as a proper noun elsewhere in the docs, they should also be updated to "NumPy" for consistency.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #120 +/- ##
=======================================
Coverage 90.52% 90.52%
=======================================
Files 4 4
Lines 728 728
=======================================
Hits 659 659
Misses 69 69 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Update project documentation and add contributor guidelines and curated configuration docs.
Documentation:
Chores: