Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the Wily complexity GitHub Action to use the multiline output syntax for step outputs and bumps the project version from a dev suffix to a release version in both configuration and runtime metadata. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #94 +/- ##
==========================================
- Coverage 91.70% 90.29% -1.42%
==========================================
Files 1 1
Lines 470 515 +45
==========================================
+ Hits 431 465 +34
- Misses 39 50 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In the workflow change, consider using a less generic heredoc delimiter than
EOF(e.g.,DIFF_EOF) to avoid potential collisions if the Wily diff output were ever to contain the stringEOFon its own line.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In the workflow change, consider using a less generic heredoc delimiter than `EOF` (e.g., `DIFF_EOF`) to avoid potential collisions if the Wily diff output were ever to contain the string `EOF` on its own line.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances
ruff-sync's URL handling capabilities and cleans up documentation for a better user experience.✨ Key Features
ruff-syncnow correctly resolves GitHub and GitLab/tree/URLs (e.g.,https://github.com/org/repo/tree/main/config), allowing users to point directly to configuration directories.ruff-syncautomatically discovers configuration files, checking forpyproject.toml,ruff.toml, and.ruff.toml(in that order).README.md"Curated Examples" section now enumerates multiple supported URL formats (Repo, Tree, Blob, Raw, Git SSH), making it easier for users to understand the tool's flexibility.🛠️ Technical Improvements
fetch_upstream_configby extracting discovery and git-cloning logic into dedicated internal functions, significantly improving maintainability (C901).try-exceptoverhead (PERF203).🧪 Validation
tests/test_url_handling.pycovering the new URL formats and discovery logic.