Conversation
…s and new HTML entry point
… workflow for publishing
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds JavaScript support to the Cedar logging library, extending it from WASM-only to support both WASM and standard JavaScript environments. The main purpose is to enable the library to work in regular browser JavaScript contexts in addition to the existing WebAssembly support.
- Adds JavaScript target configuration to both the sample application and the cedar-logging library
- Creates a new JS-specific implementation of PlatformLogTree for standard JavaScript environments
- Updates sample application to support both JS and WASM-JS targets with appropriate webpack configurations
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| sample/src/wasmJsMain/resources/index.html | New HTML entry point for the WASM-JS sample application |
| sample/src/wasmJsMain/kotlin/io/github/chilinoodles/sample/main.kt | Simplifies ComposeViewport initialization by removing explicit root element selection |
| sample/src/commonMain/kotlin/io/github/chilinoodles/sample/App.kt | Replaces wildcard imports with explicit imports and adds MAX_LOG_MESSAGES_DISPLAYED constant |
| sample/build.gradle.kts | Adds JS target configuration with webpack setup alongside existing WASM-JS target |
| gradle/libs.versions.toml | Updates dependency versions and adds kotlinx-browser dependency |
| cedar-logging/src/wasmJsMain/kotlin/com/chilinoodles/cedar/logging/trees/PlatformLogTree.wasmJs.kt | Updates Console external declaration from @jsmodule to @JsName |
| cedar-logging/src/jsMain/kotlin/com/chilinoodles/cedar/logging/trees/PlatformLogTree.js.kt | New JS-specific PlatformLogTree implementation |
| cedar-logging/build.gradle.kts | Adds JS target configuration to the library |
| .github/workflows/publish.yml | Adds GitHub Actions workflow for publishing to Maven Central |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.