Skip to content

feat: js support#3

Merged
Merkost merged 3 commits into
mainfrom
develop
Aug 29, 2025
Merged

feat: js support#3
Merkost merged 3 commits into
mainfrom
develop

Conversation

@Merkost
Copy link
Copy Markdown
Member

@Merkost Merkost commented Aug 29, 2025

No description provided.

@Merkost Merkost requested a review from Copilot August 29, 2025 00:03
@Merkost Merkost self-assigned this Aug 29, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds JavaScript support to the Cedar logging library, extending it from WASM-only to support both WASM and standard JavaScript environments. The main purpose is to enable the library to work in regular browser JavaScript contexts in addition to the existing WebAssembly support.

  • Adds JavaScript target configuration to both the sample application and the cedar-logging library
  • Creates a new JS-specific implementation of PlatformLogTree for standard JavaScript environments
  • Updates sample application to support both JS and WASM-JS targets with appropriate webpack configurations

Reviewed Changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
sample/src/wasmJsMain/resources/index.html New HTML entry point for the WASM-JS sample application
sample/src/wasmJsMain/kotlin/io/github/chilinoodles/sample/main.kt Simplifies ComposeViewport initialization by removing explicit root element selection
sample/src/commonMain/kotlin/io/github/chilinoodles/sample/App.kt Replaces wildcard imports with explicit imports and adds MAX_LOG_MESSAGES_DISPLAYED constant
sample/build.gradle.kts Adds JS target configuration with webpack setup alongside existing WASM-JS target
gradle/libs.versions.toml Updates dependency versions and adds kotlinx-browser dependency
cedar-logging/src/wasmJsMain/kotlin/com/chilinoodles/cedar/logging/trees/PlatformLogTree.wasmJs.kt Updates Console external declaration from @jsmodule to @JsName
cedar-logging/src/jsMain/kotlin/com/chilinoodles/cedar/logging/trees/PlatformLogTree.js.kt New JS-specific PlatformLogTree implementation
cedar-logging/build.gradle.kts Adds JS target configuration to the library
.github/workflows/publish.yml Adds GitHub Actions workflow for publishing to Maven Central

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread sample/src/wasmJsMain/resources/index.html
Comment thread sample/src/commonMain/kotlin/io/github/chilinoodles/sample/App.kt
@Merkost Merkost merged commit 4abfaae into main Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants