Skip to content

develop#4

Merged
Merkost merged 11 commits into
mainfrom
develop
Dec 23, 2025
Merged

develop#4
Merkost merged 11 commits into
mainfrom
develop

Conversation

@Merkost
Copy link
Copy Markdown
Member

@Merkost Merkost commented Dec 22, 2025

  • feat: Update build configuration for Kotlin Multiplatform and enhance Android library support
  • feat: Replace Cedar logging with KurrencyLog for improved logging consistency
  • feat: Remove composeHotReload plugin for cleaner build configuration

Copilot AI review requested due to automatic review settings December 22, 2025 23:00
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request modernizes the build configuration for Kotlin Multiplatform and introduces a logging abstraction layer. The changes involve removing the composeHotReload plugin, migrating from direct Cedar logging calls to a new KurrencyLog wrapper, updating dependency versions, and restructuring the Android library configuration to use the new androidKotlinMultiplatformLibrary plugin.

Key Changes:

  • Removal of composeHotReload plugin from build configuration
  • Introduction of KurrencyLogging abstraction layer that wraps Cedar logging with configurable enablement
  • Migration to androidKotlinMultiplatformLibrary plugin with inline Android configuration in Kotlin DSL
  • Version updates for Kotlin (2.2.21 → 2.3.0), AGP (8.13.1 → 8.13.2), and various AndroidX libraries

Reviewed changes

Copilot reviewed 14 out of 15 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
sample/build.gradle.kts Removes composeHotReload plugin reference
build.gradle.kts Removes composeHotReload plugin from root configuration
gradle/libs.versions.toml Updates Kotlin, AGP, and AndroidX versions; removes composeHotReload plugin definition
kurrency-core/build.gradle.kts Major restructuring: switches to androidKotlinMultiplatformLibrary plugin, moves Android config inline, changes Cedar from api to implementation, disables signing
kurrency-compose/build.gradle.kts Switches to androidKotlinMultiplatformLibrary plugin and moves Android config inline
kurrency-core/src/commonMain/kotlin/org/kimplify/kurrency/KurrencyLogging.kt Adds new logging abstraction layer with KurrencyLog wrapper around Cedar
kurrency-core/src/*/kotlin/org/kimplify/kurrency/CurrencyFormatterImpl.kt Migrates all Cedar logging calls to KurrencyLog across all platform implementations (Android, iOS, JVM, JS, WasmJS)
kurrency-core/src/commonMain/kotlin/org/kimplify/kurrency/CurrencyState.kt Migrates Cedar logging calls to KurrencyLog
kurrency-core/src/commonMain/kotlin/org/kimplify/kurrency/CurrencyMetadata.kt Migrates Cedar logging calls to KurrencyLog
kurrency-core/src/commonMain/kotlin/org/kimplify/kurrency/CurrencyFormatter.kt Migrates Cedar logging calls to KurrencyLog
Comments suppressed due to low confidence (2)

kurrency-core/build.gradle.kts:93

  • The signAllPublications() call has been commented out. This means artifacts will be published without signatures, which is typically required for Maven Central publication. If this is intentional for development/testing purposes, consider adding a comment explaining why signing is disabled. Otherwise, this should be re-enabled before publishing to Maven Central.
    signAllPublications()

kurrency-compose/build.gradle.kts:77

  • The signAllPublications() call has been commented out. This means artifacts will be published without signatures, which is typically required for Maven Central publication. If this is intentional for development/testing purposes, consider adding a comment explaining why signing is disabled. Otherwise, this should be re-enabled before publishing to Maven Central.
    signAllPublications()

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread kurrency-core/build.gradle.kts Outdated
Comment thread kurrency-compose/build.gradle.kts
Comment thread kurrency-core/build.gradle.kts
Comment thread kurrency-compose/build.gradle.kts Outdated
Comment thread kurrency-core/build.gradle.kts
@Merkost Merkost merged commit e6d4640 into main Dec 23, 2025
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants