Skip to content

Conversation

@yantosca
Copy link
Contributor

@yantosca yantosca commented Oct 14, 2025

This is the companion PR to #139. We have updated the .gitignore file to avoid inadvertently excluding Makefiles (and other files) from the util folder.

Also fixed an error in ./ci-pipelines/ci-cleanup-script.sh that caused the MCM C-I test folders to not be cleaned properly.

.gitignore
- Exclude generated Makefiles in ci-tests/* folders
- Change Makefile_* to /Makefile_*
- Change Hessian_* to Hessian_*

CHANGELOG.md
- Updated accordingly

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
@yantosca yantosca added this to the 3.4.0 milestone Oct 14, 2025
@yantosca yantosca requested a review from RolfSander October 14, 2025 16:03
@yantosca yantosca self-assigned this Oct 14, 2025
@yantosca yantosca added the bugfix Fixes a bug or a technical issue label Oct 14, 2025
.gitignore
- Removed /manual* entries, we no longer have this folder in
  the KPP repo
- Add a slash in front of each of the KPP-generated files
- Remove the *.dat entry

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
.gitignore
- Updated comment header
- Moved code to keep the folder for executables (but to ignore its
  contents) to the top
- Prefix "**/" to temporary files, files generated by the compiler,
  and files generated by KPP so that it will ignore those files
  in all folders of the KPP repo
- Updated comments to make it more clear whether files will be ignored
  in a particular folder or in all folders
- Remove duplicated entries

CHANGELOG.md
- Updated accordingly

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
@yantosca yantosca linked an issue Oct 14, 2025 that may be closed by this pull request
.gitignore
- Create a new section of files that should not be ignored at the
  end of the file
- Explicitly request that docs/figures/*.pdf not be ignored
- Explicity request that util/{*.c, *.f, *.f90, *.h, *,m} and u
  util/Makefile* files should not be ignored
- Now ignore __pycache__ folders everywhere

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
.ci-pipelines/ci-cleanup-script.sh
- Now use "mcm" as the second argument to clean_ci_test_folder
  for the MCM C-I tests.

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
Copy link
Contributor

@RolfSander RolfSander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now

@yantosca yantosca merged commit 698c840 into dev Oct 15, 2025
10 checks passed
@yantosca yantosca deleted the bugfix/gitignore branch October 15, 2025 14:50
@yantosca yantosca mentioned this pull request Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Fixes a bug or a technical issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ignore Makefile_* ?

3 participants