Prevent storing bytes in cache (fixes #1142)#1143
Merged
Conversation
Contributor
|
I'd rather raise when trying to cache bytes, so that we have clean signature in the interface. But if you have good reason to cast, please do! |
Member
Author
|
Yes that was my opinion too. Let's do that then :) Also it might break a bunch of plugins but it doesn't matter. |
Contributor
We can bump a major, no problem. #1144 also introduces breaking changes in |
leplatrem
approved these changes
Mar 8, 2017
kinto/core/cache/testing.py
Outdated
| self.assertEqual(*setget('foobar', {'b': [1, 2]})) | ||
| self.assertEqual(*setget('foobar', 3.14)) | ||
|
|
||
| def test_bytes_are_converted_to_unicode(self): |
Contributor
There was a problem hiding this comment.
leftover: test title does not match
leplatrem
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wonder if we should do it like that or rather to raise an error when trying to cache bytes.
Fixes #1142
r? @leplatrem