Merged
Conversation
Member
|
I'm adding a few more details. |
Member
|
updated the PR with some more info and rephrasing. |
Member
There was a problem hiding this comment.
I'd like to talk about the Token Server here as an example.
Member
There was a problem hiding this comment.
I removed it because I think it just adds some pointers to a mozilla specific tool. We can add it as an example, though. Updating the docs accordingly.
Contributor
Author
There was a problem hiding this comment.
nit: unless the node becomes unreachable ?
Contributor
Author
|
Should I take over on the branch ? |
Contributor
Author
|
Ready to review/merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Imported from @Natim comment in pad