Skip to content

feat(type): use arrow type to support vectorization#22

Merged
loloxwg merged 1 commit intomainfrom
feat/storage
Jul 20, 2023
Merged

feat(type): use arrow type to support vectorization#22
loloxwg merged 1 commit intomainfrom
feat/storage

Conversation

@loloxwg
Copy link
Copy Markdown
Member

@loloxwg loloxwg commented Jul 13, 2023 •
edited
Loading

What problem does this PR solve?

  • use arrow type to support vectorization
  • sqlparser::ast::DataType -> LogicalType -> arrow::datatypes::DataType
  • change catalog name to avoid confusion.
  • remove some unused import but there are some possible uses that have not been removed.
  • memory storage is not complete.
  • remove gpt code reviewer.
  • change ci workflow.
  • add toolchain of rust

What is changed and how it works?

Code changes

  • Has Rust code change
  • Has CI related scripts change

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Note for reviewer

  • check type and value in types folder

@loloxwg loloxwg requested review from KKould and eliasyaoyc July 13, 2023 16:21
@loloxwg loloxwg added the enhancement New feature or request label Jul 13, 2023
@loloxwg loloxwg mentioned this pull request Jul 14, 2023
Merged
9 tasks
KKould
KKould approved these changes Jul 14, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@KKould KKould left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@loloxwg
feat(type): use arrow type to support vectorization
30ba28d 
- change catalog name to avoid confusion.
- remove some unused import but there are some possible uses that have not been removed.
- memory storage is not complete.
- remove gpt code reviewer.
- change ci workflow.
- add toolchain of rust
@KipData KipData deleted a comment from github-actions Bot Jul 14, 2023
@loloxwg loloxwg mentioned this pull request Jul 14, 2023
Closed
11 tasks
@loloxwg loloxwg added this to the v0.1 milestone Jul 14, 2023
@loloxwg loloxwg merged commit 52b897c into main Jul 20, 2023
@loloxwg loloxwg deleted the feat/storage branch July 20, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KKould KKould KKould approved these changes

@eliasyaoyc eliasyaoyc Awaiting requested review from eliasyaoyc

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

v0.1

Development

Successfully merging this pull request may close these issues.

2 participants

@loloxwg @KKould