feat(execute): add create table PhysicalOperator#27
Merged
KKould merged 3 commits intoKipData:mainfrom Jul 26, 2023
Merged
Conversation
loloxwg
force-pushed
the
feat/execute
branch
2 times, most recently
from
b5a44cd to
459a133
Compare
- bind column ref
loloxwg
commented
Jul 26, 2023
|
|
||
| let mut builder = PhysicalPlanBuilder::new(); | ||
| let operator = builder.build_plan(&logical_plan)?; | ||
| println!("operator: {:#?}", logical_plan); |
Member
Author
There was a problem hiding this comment.
Suggested change
| println!("operator: {:#?}", logical_plan); | |
| println!("operator: {:#?}", operator); |
loloxwg
commented
Jul 26, 2023
|
|
||
| let _ = storage.create_table( | ||
| plan.table_name.as_str(), | ||
| vec![RecordBatch::new_empty(schema)] |
Member
Author
There was a problem hiding this comment.
- field
- schema
- batch record
good job
loloxwg
commented
Jul 26, 2023
| struct Inner { | ||
| catalog: RootCatalog, | ||
| tables: HashMap<TableId, InMemoryTable>, | ||
| tables: Vec<InMemoryTable>, |
Member
Author
There was a problem hiding this comment.
Why did you change from a hash table to an array?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
create table execute
Issue link: #5
What is changed and how it works?
Code changes
Check List
Tests
Side effects
Note for reviewer
cargo fmt code
add rust-toolchain to enable ci