feat(hash_join): implement basic Inner/Left/Right/Full Join operations#43
Merged
KKould merged 7 commits intoKipData:mainfrom Aug 11, 2023
Merged
feat(hash_join): implement basic Inner/Left/Right/Full Join operations#43KKould merged 7 commits intoKipData:mainfrom
KKould merged 7 commits intoKipData:mainfrom
Conversation
found a problem that needs to be fixed: - when the `Projection` operator executes eval_column, the reading data is abnormal due to the duplication of the ColumnIdx subscript of the Catalog So `Binder::bind_project` need to support join
By marshaling Column and rewriting `ScalarExpression` to convert `ColumnRef` to `InputRef`
… data when inserting
…ncel converting InputRef to ColumnRef
…esponding Select nullable processing to avoid rewrite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
found a problem that needs to be fixed:
Projectionoperator executes eval_column, the reading data is abnormal due to the duplication of the ColumnIdx subscript of the Catalog SoBinder::bind_projectneed to support joinWhat problem does this PR solve?
Add corresponding issue link with summary if exists -->
Issue link:
What is changed and how it works?
Code changes
Check List
Tests
Side effects
Note for reviewer