Refactor Column Pruning and support where case: like and not like, is not null
#93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tection under self-direction
…ons ahead of time to avoid double calculations
KKould
requested review from
lewiszlw and
loloxwg
and removed request for
lewiszlw
Member
|
This pr contains like/null expr, ColumnCatalog refactoring, constant calculation, column pruning, etc, not friendly to reviewer. You could split pr into smaller pieces next time. |
KKould
added a commit
to KKould/KipSQL
that referenced
this pull request
Nov 11, 2023
…, `is not null` (KipData#93) * refactor(column_pruning): reconstruct column clipping using Column detection under self-direction 1 * feat(simplify): add `constant_calculation` compute constant calculations ahead of time to avoid double calculations * feat: support like operator * feat: support is not null operator * ci: nightly version * config: nightly version update * ci: config toolchain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed and how it works?
Code changes
Check List
Tests
Side effects
Note for reviewer