Skip to content

Bugfix/41#56

Merged
MrLutik merged 2 commits intomasterfrom
bugfix/41
Dec 4, 2025
Merged

Bugfix/41#56
MrLutik merged 2 commits intomasterfrom
bugfix/41

Conversation

@kobs30
Copy link
Contributor

@kobs30 kobs30 commented Dec 3, 2025

Date
/api/transactions?start_date=2025-11-17T16:45:35.710911842Z (ISO format)

Sort
/api/transactions?sort=asc (date is default field) OR /api/transactions?sort=field_name:asc

Type
/api/transactions?types[]=/cosmos.bank.v1beta1.MsgSend (transaction type as cosmos value)
We can add aliases (send, multisend and etc), but we should do it every time for a new transaction type added to the sekai. It's better to use proto naming.

@MrLutik
Copy link
Contributor

MrLutik commented Dec 3, 2025

@muknta
Date
/api/transactions?start_date=2025-11-17T16:45:35.710911842Z (ISO format)

What format is used on frontend side? ISO or epoch

@MrLutik
Copy link
Contributor

MrLutik commented Dec 3, 2025

@kobs30 @muknta
We should solve the "direction" parameter.
Direction is similar to etherscan.io in and out txs. We have to check message type and address to determine whether it's inbound or outbound tx.
Ref.: issue #41 comment

@muknta
Copy link
Collaborator

muknta commented Dec 3, 2025

@MrLutik regarding the date format - we use currently the epoch.

I'll alter the implementation to ISO if needed

@muknta
Copy link
Collaborator

muknta commented Dec 3, 2025

@kobs30 proto naming with transaction types is fine

@MrLutik
Copy link
Contributor

MrLutik commented Dec 3, 2025

Summary

Issue Status Tested
Date
Sort
Msg type
Address
Direction

@MrLutik MrLutik merged commit 4694721 into master Dec 4, 2025
44 checks passed
@kobs30
Copy link
Contributor Author

kobs30 commented Dec 4, 2025

@MrLutik regarding the date format - we use currently the epoch.

I'll alter the implementation to ISO if needed

I can implement conversion on the BE side. As you want. Or double format support: ISO and UNIX

@MrLutik
Copy link
Contributor

MrLutik commented Dec 4, 2025

@MrLutik regarding the date format - we use currently the epoch.

I'll alter the implementation to ISO if needed

@kobs30: no changes needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants