Skip to content

Move WordPress Libraries Methods to Trait#122

Open
n7studios wants to merge 5 commits intomasterfrom
add-get-body-html
Open

Move WordPress Libraries Methods to Trait#122
n7studios wants to merge 5 commits intomasterfrom
add-get-body-html

Conversation

@n7studios
Copy link
Contributor

Summary

To facilitate using the ConvertKit_API_Traits trait directly in the Kit WordPress Libraries, without any changes, this PR standardises the trait by:

  • Adding the get_body_html method, which uses DOMDocument vs. string search/replace
  • Removes the unused and deprecated strip_html_head_body_tags method
  • Fixes a bug in convert_relative_to_absolute_urls that would stop after the first change to a node in the NodeList

Testing

  • ConvertKitMethodsTest: Test the convert_relative_to_absolute_urls and get_body_html methods work correctly with unit tests

Checklist

@n7studios n7studios requested review from a team, ciccio-kit and noelherrick and removed request for a team March 11, 2026 02:41
@n7studios n7studios marked this pull request as ready for review March 11, 2026 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant