Conversation
…imating with a series of stright lines, with region selection working using arc approximation as well
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1158 +/- ##
=======================================
Coverage ? 29.83%
=======================================
Files ? 34
Lines ? 1619
Branches ? 0
=======================================
Hits ? 483
Misses ? 1136
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Apr 20, 2026
alteous
requested changes
Apr 23, 2026
| /// A general exact curve segment. | ||
| /// Start at the current path "pen" and end at the final control point. | ||
| /// In the first pass this is used for non-rational open-uniform spline curves. | ||
| Curve { |
Contributor
There was a problem hiding this comment.
Please call this Spline or BSpline or something of that nature. Curve is too abstract.
| /// Degree of the curve. | ||
| degree: u32, | ||
| /// Whether to use the homogeneous `w` component as a rational weight. | ||
| rational: bool, |
Contributor
There was a problem hiding this comment.
We can infer this from the control points instead.
Contributor
|
The spline/line constraint is awesome! |
alteous
reviewed
Apr 23, 2026
| /// In the first pass this is used for non-rational open-uniform spline curves. | ||
| Curve { | ||
| /// Degree of the curve. | ||
| degree: u32, |
Contributor
There was a problem hiding this comment.
The knot vector isn't customisable here but that can come later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to KittyCAD/modeling-app#11103
ZDS PR: KittyCAD/modeling-app#11127
EZPZ PR: KittyCAD/ezpz#247
Modeling-api PR: #1158
Engine PR: https://github.com/KittyCAD/engine/pull/4468