Cubic millimeter support#1191
Merged
Merged
Conversation
adamchalmers
force-pushed
the
achalmers/mm3
branch
from
d5b6884 to
ca70694
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1191 +/- ##
=======================================
Coverage ? 29.77%
=======================================
Files ? 35
Lines ? 1632
Branches ? 0
=======================================
Hits ? 486
Misses ? 1146
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JordanNoone
approved these changes
May 7, 2026
adamchalmers
force-pushed
the
achalmers/mm3
branch
from
ca70694 to
381d962
Compare
adamchalmers
force-pushed
the
achalmers/mm3
branch
from
381d962 to
bec82a0
Compare
JordanNoone
pushed a commit
that referenced
this pull request
May 7, 2026
## Added * Support Cubic Millimeter as a volume (#1191)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of KittyCAD/modeling-app#11474
Relies on rust-embedded-community/rust-measurements#68
As far as I can tell, this should Just Work once we update the engine. It doesn't cause any compile errors anywhere, the various services (frontend, CLI, engine etc) just need to update and pull this in so they understand what a cubic millimeter is, if something requests it.